linux-kernel - Re: [PATCH net 1/1] net: stmmac: Fix zero-division error when disabling tc cbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240912153913.GO572255@kernel.org>
Date: Thu, 12 Sep 2024 16:39:13 +0100
From: Simon Horman <horms@...nel.org>
To: KhaiWenTan <khai.wen.tan@...ux.intel.com>
Cc: Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Jose Abreu <joabreu@...opsys.com>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>,
	Xiaolei Wang <xiaolei.wang@...driver.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org,
	Choong Yong Liang <yong.liang.choong@...ux.intel.com>,
	Tan Khai Wen <khai.wen.tan@...el.com>
Subject: Re: [PATCH net 1/1] net: stmmac: Fix zero-division error when
 disabling tc cbs

On Thu, Sep 12, 2024 at 04:37:30PM +0100, Simon Horman wrote:
> On Thu, Sep 12, 2024 at 09:55:41AM +0800, KhaiWenTan wrote:
> > The commit b8c43360f6e4 ("net: stmmac: No need to calculate speed divider
> > when offload is disabled") allows the "port_transmit_rate_kbps" to be
> > set to a value of 0, which is then passed to the "div_s64" function when
> > tc-cbs is disabled. This leads to a zero-division error.
> > 
> > When tc-cbs is disabled, the idleslope, sendslope, and credit values the
> > credit values are not required to be configured. Therefore, adding a return
> > statement after setting the txQ mode to DCB when tc-cbs is disabled would
> > prevent a zero-division error.
> > 
> > Fixes: b8c43360f6e4 ("net: stmmac: No need to calculate speed divider when offload is disabled")
> > Cc: <stable@...r.kernel.org>
> > Co-developed-by: Choong Yong Liang <yong.liang.choong@...ux.intel.com>
> > Signed-off-by: Choong Yong Liang <yong.liang.choong@...ux.intel.com>
> > Signed-off-by: KhaiWenTan <khai.wen.tan@...ux.intel.com>

...

One more thing, if you do post an updated patch, please
be sure to wait until 24h after the original patch was posted.

https://docs.kernel.org/process/maintainer-netdev.html