[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240912155830.14688-1-jdamato@fastly.com>
Date: Thu, 12 Sep 2024 15:58:30 +0000
From: Joe Damato <jdamato@...tly.com>
To: netdev@...r.kernel.org
Cc: Joe Damato <jdamato@...tly.com>,
Pavan Chebbi <pavan.chebbi@...adcom.com>,
Michael Chan <mchan@...adcom.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
linux-kernel@...r.kernel.org (open list)
Subject: [PATCH net-next] tg3: Link IRQs to NAPI instances
Link IRQs to NAPI instances with netif_napi_set_irq. This information
can be queried with the netdev-genl API.
Compare the output of /proc/interrupts for my tg3 device with the output of
netdev-genl after applying this patch:
$ cat /proc/interrupts | grep eth0 | cut -f1 --delimiter=':'
331
332
333
334
335
$ ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
--dump napi-get --json='{"ifindex": 2}'
[{'id': 149, 'ifindex': 2, 'irq': 335},
{'id': 148, 'ifindex': 2, 'irq': 334},
{'id': 147, 'ifindex': 2, 'irq': 333},
{'id': 146, 'ifindex': 2, 'irq': 332},
{'id': 145, 'ifindex': 2, 'irq': 331}]
Signed-off-by: Joe Damato <jdamato@...tly.com>
---
drivers/net/ethernet/broadcom/tg3.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index 378815917741..c187b13ab3e6 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -7393,6 +7393,14 @@ static int tg3_poll(struct napi_struct *napi, int budget)
return work_done;
}
+static void tg3_napi_set_irq(struct tg3 *tp)
+{
+ int i;
+
+ for (i = 0; i < tp->irq_cnt; i++)
+ netif_napi_set_irq(&tp->napi[i].napi, tp->napi[i].irq_vec);
+}
+
static void tg3_napi_disable(struct tg3 *tp)
{
int i;
@@ -11652,7 +11660,7 @@ static int tg3_start(struct tg3 *tp, bool reset_phy, bool test_irq,
goto out_ints_fini;
tg3_napi_init(tp);
-
+ tg3_napi_set_irq(tp);
tg3_napi_enable(tp);
for (i = 0; i < tp->irq_cnt; i++) {
--
2.25.1
Powered by blists - more mailing lists