linux-kernel - Re: [PATCH] i3c: master: svc: Fix use after free vulnerability in svc_i3c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <C05F548F941D5F36+47d9e505.c28c.191e7288a6e.Coremail.kxwang23@m.fudan.edu.cn>
Date: Fri, 13 Sep 2024 00:54:39 +0800 (CST)
From: "Kaixin Wang" <kxwang23@...udan.edu.cn>
To: "Miquel Raynal" <miquel.raynal@...tlin.com>
Cc: "Frank Li" <Frank.li@....com>, 21210240012@...udan.edu.cn, 
	21302010073@...udan.edu.cn, conor.culhane@...vaco.com, 
	alexandre.belloni@...tlin.com, linux-i3c@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i3c: master: svc: Fix use after free vulnerability in
 svc_i3c_master Driver Due to Race Condition



在 2024-09-12 14:57:09，"Miquel Raynal" <miquel.raynal@...tlin.com> 写道：
>Hi,
>
>Frank.li@....com wrote on Wed, 11 Sep 2024 11:24:57 -0400:
>
>> On Wed, Sep 11, 2024 at 11:01:35PM +0800, Kaixin Wang wrote:
>> > In the svc_i3c_master_probe function, &master->hj_work is bound with
>> > svc_i3c_master_hj_work, &master->ibi_work is bound with
>> > svc_i3c_master_ibi_work. And svc_i3c_master_ibi_work  can start the
>> > hj_work, svc_i3c_master_irq_handler can start the ibi_work.
>> >
>> > If we remove the module which will call svc_i3c_master_remove to
>> > make cleanup, it will free master->base through i3c_master_unregister
>> > while the work mentioned above will be used. The sequence of operations
>> > that may lead to a UAF bug is as follows:
>> >
>> > CPU0                                         CPU1
>> >
>> >                                     | svc_i3c_master_hj_work
>> > svc_i3c_master_remove               |
>> > i3c_master_unregister(&master->base)|
>> > device_unregister(&master->dev)     |
>> > device_release                      |
>> > //free master->base                 |
>> >                                     | i3c_master_do_daa(&master->base)
>> >                                     | //use master->base
>> >
>> > Fix it by ensuring that the work is canceled before proceeding with the
>> > cleanup in svc_i3c_master_remove.
>> >
>> > Signed-off-by: Kaixin Wang <kxwang23@...udan.edu.cn>
>> > ---  
>> 
>> Please add fixes tag and cc stable.
>
>Yes indeed. Otherwise looks good to me once this fixed.
>
>Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>
>
>Thanks,
>Miquèl
>

Thanks for the review!

Best regards,
Kaixin Wang