linux-kernel - Re: [PATCH] um: Fix the return value of elf_core_copy_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78364371.37121.1726167098936.JavaMail.zimbra@nod.at>
Date: Thu, 12 Sep 2024 20:51:38 +0200 (CEST)
From: Richard Weinberger <richard@....at>
To: Tiwei Bie <tiwei.btw@...group.com>
Cc: anton ivanov <anton.ivanov@...bridgegreys.com>, 
	Johannes Berg <johannes@...solutions.net>, 
	linux-um <linux-um@...ts.infradead.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] um: Fix the return value of elf_core_copy_task_fpregs

----- Ursprüngliche Mail -----
> Von: "Tiwei Bie" <tiwei.btw@...group.com>
> An: "richard" <richard@....at>, "anton ivanov" <anton.ivanov@...bridgegreys.com>, "Johannes Berg"
> <johannes@...solutions.net>
> CC: "linux-um" <linux-um@...ts.infradead.org>, "linux-kernel" <linux-kernel@...r.kernel.org>, "Tiwei Bie"
> <tiwei.btw@...group.com>
> Gesendet: Mittwoch, 28. August 2024 15:51:40
> Betreff: [PATCH] um: Fix the return value of elf_core_copy_task_fpregs

> This function is expected to return a boolean value, which should be
> true on success and false on failure.
> 
> Fixes: d1254b12c93e ("uml: fix x86_64 core dump crash")
> Signed-off-by: Tiwei Bie <tiwei.btw@...group.com>
> ---
> arch/um/kernel/process.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/um/kernel/process.c b/arch/um/kernel/process.c
> index be2856af6d4c..3cc2b663aa78 100644
> --- a/arch/um/kernel/process.c
> +++ b/arch/um/kernel/process.c
> @@ -291,7 +291,8 @@ unsigned long __get_wchan(struct task_struct *p)
> int elf_core_copy_task_fpregs(struct task_struct *t, elf_fpregset_t *fpu)
> {
> 	int cpu = current_thread_info()->cpu;
> +	int pid = userspace_pid[cpu];
> 
> -	return save_i387_registers(userspace_pid[cpu], (unsigned long *) fpu);
> +	return save_i387_registers(pid, (unsigned long *) fpu) == 0;

Why a new local variable?

Thanks,
//richard