linux-kernel - Re: [PATCH v2 1/2] staging: vt6655: Rename variable apTD0Rings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65c67cb1-59d5-45dd-9e05-6b82a0f0181f@gmail.com>
Date: Thu, 12 Sep 2024 21:09:22 +0200
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Xingquan Liu <b1n@....io>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] staging: vt6655: Rename variable apTD0Rings

On 9/12/24 18:26, Xingquan Liu wrote:
> Rename variable apTD0Rings to ap_td0_rings
> to fix checkpatch warning Avoid CamelCase.
> 
> Signed-off-by: Xingquan Liu<b1n@....io>
> ---
>   drivers/staging/vt6655/card.c        |  6 +++---
>   drivers/staging/vt6655/device.h      |  2 +-
>   drivers/staging/vt6655/device_main.c | 14 +++++++-------
>   3 files changed, 11 insertions(+), 11 deletions(-)

Hi Xingquan,

Please use a change history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
So your next patch is v3.

Please do not break lines of the description to early. Up to 75 
characters can be used.

Thanks for your support.

Bye Philipp