linux-kernel - Re: [PATCH v1] drm/xe: Use ERR_CAST to return an error-valued pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZuNBOYn/U+At5Vog@DUT025-TGLU.fm.intel.com>
Date: Thu, 12 Sep 2024 19:30:01 +0000
From: Matthew Brost <matthew.brost@...el.com>
To: Yu Jiaoliang <yujiaoliang@...o.com>
CC: Lucas De Marchi <lucas.demarchi@...el.com>, Thomas
 Hellström <thomas.hellstrom@...ux.intel.com>, Rodrigo Vivi
	<rodrigo.vivi@...el.com>, Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
	Simona Vetter <simona@...ll.ch>, <intel-xe@...ts.freedesktop.org>,
	<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
	<opensource.kernel@...o.com>
Subject: Re: [PATCH v1] drm/xe: Use ERR_CAST to return an error-valued pointer

On Mon, Sep 09, 2024 at 04:13:57PM +0000, Matthew Brost wrote:
> On Fri, Sep 06, 2024 at 03:01:09PM +0800, Yu Jiaoliang wrote:
> > Instead of directly casting and returning an error-valued pointer,
> > use ERR_CAST to make the error handling more explicit and improve
> > code clarity.
> > 
> > Signed-off-by: Yu Jiaoliang <yujiaoliang@...o.com>
> 
> Reviewed-by: Matthew Brost <matthew.brost@...el.com>
> 

Merged to drm-xe-next.

Thanks for the patch.

Matt

> > ---
> >  drivers/gpu/drm/xe/xe_sa.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/xe/xe_sa.c b/drivers/gpu/drm/xe/xe_sa.c
> > index fe2cb2a96f78..e055bed7ae55 100644
> > --- a/drivers/gpu/drm/xe/xe_sa.c
> > +++ b/drivers/gpu/drm/xe/xe_sa.c
> > @@ -53,7 +53,7 @@ struct xe_sa_manager *xe_sa_bo_manager_init(struct xe_tile *tile, u32 size, u32
> >  	if (IS_ERR(bo)) {
> >  		drm_err(&xe->drm, "failed to allocate bo for sa manager: %ld\n",
> >  			PTR_ERR(bo));
> > -		return (struct xe_sa_manager *)bo;
> > +		return ERR_CAST(bo);
> >  	}
> >  	sa_manager->bo = bo;
> >  	sa_manager->is_iomem = bo->vmap.is_iomem;
> > -- 
> > 2.34.1
> >