linux-kernel - Re: [PATCH v3 2/2] of/irq: Use helper to define resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240912195753.GA555349-robh@kernel.org>
Date: Thu, 12 Sep 2024 14:57:53 -0500
From: Rob Herring <robh@...nel.org>
To: Vasileios Amoiridis <vassilisamir@...il.com>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	saravanak@...gle.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] of/irq: Use helper to define resources

On Wed, Sep 11, 2024 at 07:34:38PM +0200, Vasileios Amoiridis wrote:
> On Wed, Sep 11, 2024 at 07:15:33PM +0300, Andy Shevchenko wrote:
> > On Wed, Sep 11, 2024 at 06:02:53PM +0200, Vasileios Amoiridis wrote:
> > > Resources definition can become simpler and more organised by using the
> > > dedicated helpers.
> > 
> > ...
> > 
> > > -		r->start = r->end = irq;
> > > -		r->flags = IORESOURCE_IRQ | irq_get_trigger_type(irq);
> > > -		r->name = name ? name : of_node_full_name(dev);
> > > +		*r = DEFINE_RES_IRQ_NAMED(irq, name ? name : of_node_full_name(dev));
> > 
> > Hmm... It seems you haven't replied to me why you avoid using Elvis here,
> > while at it.
> > 
> > Also for both patches you probably want
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > 
> > > +		r->flags |= irq_get_trigger_type(irq);
> > 
> > -- 
> > With Best Regards,
> > Andy Shevchenko
> > 
> > 
> 
> 
> Hi Andy,
> 
> Thanks for your message once again!!
> 
> I honestly didn't know this operator, I just found out about it.
> Looks like it fits here, I can definitely use it.
> 
> I am going to leave it for a while to see if Krzysztof or Rob have
> any other comments and then I can send as you proposed.

No comments from me, please send with the updates.

Rob