linux-kernel - Re: [PATCH] staging: vt6655: mac.h: Fix possible precedence issue in macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ILhrP61gFh-bKmnqG1DTIWCjW8yXNVEI1mGa2Fm-y_yhZ4kV-WCxXoid_Yuy7w4-kyH4QVT7B3h-OUUBH0rAtjCM8P5tMQxG_zLjKrq4NEM=@protonmail.com>
Date: Thu, 12 Sep 2024 20:18:18 +0000
From: Dominik Karol Piątkowski <dominik.karol.piatkowski@...tonmail.com>
To: Philipp Hortmann <philipp.g.hortmann@...il.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vt6655: mac.h: Fix possible precedence issue in macros

On Thursday, September 12th, 2024 at 21:29, Philipp Hortmann <philipp.g.hortmann@...il.com> wrote:

> 
> 
> On 9/11/24 20:02, Dominik Karol Piątkowski wrote:
> 
> > It is safer to put macro arguments in parentheses. This way, accidental
> > operator precedence issues can be avoided.
> > 
> > Signed-off-by: Dominik Karol Piątkowski dominik.karol.piatkowski@...tonmail.com
> > ---
> > drivers/staging/vt6655/mac.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
> > index acf931c3f5fd..a33af2852227 100644
> > --- a/drivers/staging/vt6655/mac.h
> > +++ b/drivers/staging/vt6655/mac.h
> > @@ -537,9 +537,9 @@
> > 
> > /--------------------- Export Macros ------------------------------/
> > 
> > -#define VT6655_MAC_SELECT_PAGE0(iobase) iowrite8(0, iobase + MAC_REG_PAGE1SEL)
> > +#define VT6655_MAC_SELECT_PAGE0(iobase) iowrite8(0, (iobase) + MAC_REG_PAGE1SEL)
> > 
> > -#define VT6655_MAC_SELECT_PAGE1(iobase) iowrite8(1, iobase + MAC_REG_PAGE1SEL)
> > +#define VT6655_MAC_SELECT_PAGE1(iobase) iowrite8(1, (iobase) + MAC_REG_PAGE1SEL)
> > 
> > #define MAKEWORD(lb, hb) \
> > ((unsigned short)(((unsigned char)(lb)) | (((unsigned short)((unsigned char)(hb))) << 8)))
> 
> 
> 
> Hi Dominik,
> 
> git shows your name with the following characters:
> 
> Author: Dominik Karol Pi^Etkowski dominik.karol.piatkowski@...tonmail.com
> 
> 
> I think it is better to change your name to only english letters.
> 
> If you send in a second version of this patch please use a change
> history. Description from Dan under:
> https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
> 
> Thanks for your support.
> 
> Bye Philipp

Hi Philipp,

Thanks for testing my patch.

About the mangled author field - it was sent as
"From: =?UTF-8?q?Dominik=20Karol=20Pi=C4=85tkowski?= <dominik.karol.piatkowski@...tonmail.com>"
and =C4=85 in UTF-8 is indeed 'ą' character. When looking at linux-next tree,
previously accepted patches also seem to have 'ą' as intended. I am not sure
why you are seeing "^E" instead.

Thanks,
Dominik Karol