linux-kernel - Re: [PATCH v2] SLUB: Add support for per object memory policies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5f9e2cbd-a7a6-53c1-8272-6f91fb525571@gentwo.org>
Date: Thu, 12 Sep 2024 15:21:02 -0700 (PDT)
From: "Christoph Lameter (Ampere)" <cl@...two.org>
To: Matthew Wilcox <willy@...radead.org>
cc: kernel test robot <lkp@...el.com>, 
    Christoph Lameter via B4 Relay <devnull+cl.gentwo.org@...nel.org>, 
    Vlastimil Babka <vbabka@...e.cz>, Pekka Enberg <penberg@...nel.org>, 
    David Rientjes <rientjes@...gle.com>, Joonsoo Kim <iamjoonsoo.kim@....com>, 
    Andrew Morton <akpm@...ux-foundation.org>, 
    Roman Gushchin <roman.gushchin@...ux.dev>, 
    Hyeonggon Yoo <42.hyeyoo@...il.com>, Yang Shi <shy828301@...il.com>, 
    oe-kbuild-all@...ts.linux.dev, 
    Linux Memory Management List <linux-mm@...ck.org>, 
    linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
    Huang Shijie <shijie@...amperecomputing.com>
Subject: Re: [PATCH v2] SLUB: Add support for per object memory policies

On Thu, 12 Sep 2024, Matthew Wilcox wrote:

> On Thu, Sep 12, 2024 at 09:15:34AM -0700, Christoph Lameter (Ampere) wrote:
> > > sparse warnings: (new ones prefixed by >>)
> > > >> mm/slub.c:222:1: sparse: sparse: symbol 'strict_numa' was not declared. Should it be static?
> >
> >
> > Ummm.. This code declares strict_numa. Whats wrong with sparc64 / sparse ?
> >
> > > vim +/strict_numa +222 mm/slub.c
> > >
> > >    220
> > >    221	#ifdef CONFIG_NUMA
> > >  > 222	DEFINE_STATIC_KEY_FALSE(strict_numa);
>
> maybe this should be:
>
> static DEFINE_STATIC_KEY_FALSE(strict_numa);

Ah double staticity. Thanks.




>From b239f4f26094845af74b091682f0bdcae56b5123 Mon Sep 17 00:00:00 2001
From: Christoph Lameter <cl@...two.org>
Date: Thu, 12 Sep 2024 15:15:07 -0700
Subject: [PATCH 3/3] [SLUB] Make strict_numa static

strict_numa is only used in mm/slub.c so it can be static.

Signed-off-by: Christoph Lameter <cl@...ux.com>
---
 mm/slub.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/slub.c b/mm/slub.c
index 2fa7c35e076a..56e320082c09 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -219,7 +219,7 @@ DEFINE_STATIC_KEY_FALSE(slub_debug_enabled);
 #endif		/* CONFIG_SLUB_DEBUG */

 #ifdef CONFIG_NUMA
-DEFINE_STATIC_KEY_FALSE(strict_numa);
+static DEFINE_STATIC_KEY_FALSE(strict_numa);
 #endif

 /* Structure holding parameters for get_partial() call chain */
-- 
2.39.2