linux-kernel - Re: [PATCH 8/8] addon_boards: mikrobus: Add GPS3 Click

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <419bf74e-74cb-46ca-95d0-03b3bab3948d@de.bosch.com>
Date: Thu, 12 Sep 2024 09:29:01 +0200
From: Dirk Behme <dirk.behme@...bosch.com>
To: Ayush Singh <ayush@...gleboard.org>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>, Ayush Singh <ayushdevel1325@...il.com>
CC: <fabien.parent@...aro.org>, <d-gole@...com>,
	<lorforlinux@...gleboard.org>, <jkridner@...gleboard.org>,
	<robertcnelson@...gleboard.org>, Andrew Davis <afd@...com>, Miguel Ojeda
	<ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng
	<boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, Benno Lossin
	<benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, "Alice
 Ryhl" <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, Derek Kiernan <derek.kiernan@....com>, Dragan Cvetic
	<dragan.cvetic@....com>, Arnd Bergmann <arnd@...db.de>, Nishanth Menon
	<nm@...com>, Vignesh Raghavendra <vigneshr@...com>, Tero Kristo
	<kristo@...nel.org>, <linux-kernel@...r.kernel.org>,
	<rust-for-linux@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 8/8] addon_boards: mikrobus: Add GPS3 Click

On 12.09.2024 09:16, Ayush Singh wrote:
> On 9/12/24 01:34, Greg Kroah-Hartman wrote:
> 
>> On Wed, Sep 11, 2024 at 09:26:06PM +0530, Ayush Singh wrote:
>>> On 9/11/24 20:28, Greg Kroah-Hartman wrote:
>>>
>>>> On Wed, Sep 11, 2024 at 07:57:25PM +0530, Ayush Singh wrote:
>>>>> - GPS3 Click is a UART MikroBUS addon Board
>>>>>
>>>>> Link: https://www.mikroe.com/gps-3-click
>>>>>
>>>>> Signed-off-by: Ayush Singh <ayush@...gleboard.org>
>>>>> ---
>>>>>    addon_boards/mikrobus/Makefile         |  1 +
>>>>>    addon_boards/mikrobus/mikroe-1714.dtso | 28 
>>>>> ++++++++++++++++++++++++++++
>>>> Odd top-level directory for the kernel, are you sure this is correct?
>>>>
>>>> thanks,
>>>>
>>>> greg k-h
>>>>
>>> Well, it is kinda a temporary location, since well, I could not find 
>>> a good
>>> place for board overlays but a top-level location seems better than 
>>> putting
>>> them in any arch specific location. I am open to moving them to a more
>>> suitable location if we have one.
>> top-level location is not ok for something so tiny and "special".  Just
>> put it where all other dtso files go.
>>
>> thanks,
>>
>> greg k-h
> 
> 
> So here are the directories where dtso files currently go:
> 
> ❯ find . -type f -name "*.dtso" -printf "%h\n" | sort -u
> ./arch/arm64/boot/dts/amlogic
> ./arch/arm64/boot/dts/freescale
> ./arch/arm64/boot/dts/mediatek
> ./arch/arm64/boot/dts/qcom
> ./arch/arm64/boot/dts/renesas
> ./arch/arm64/boot/dts/rockchip
> ./arch/arm64/boot/dts/ti
> ./arch/arm64/boot/dts/xilinx
> ./arch/arm/boot/dts/nxp/imx
> ./arch/arm/boot/dts/ti/omap
> ./drivers/clk
> ./drivers/of
> ./drivers/of/unittest-data
> 
> 
> Out of these, `drivers/of` and `drivers/of/unittest-data` contain 
> unittest dtso, so probably not the place.
> 
> And the `arch/arm` and `arch/arm64` are for arch specific stuff. 
> MikroBUS is supported in RISC-V boards as well (BeagleV-Ahead). So 
> probably not the correct location either.
> 
> Maybe something like `arch/common/addon_boards` would be better?

Whats about

drivers/misc/mikrobus/mikrobus.rs
drivers/misc/mikrobus/mikroe-1714.dtso
drivers/misc/mikrobus/mikroe-5761-i2c.dtso

?

Dirk