linux-kernel - Re: [PATCH 1/9] mfd: Add driver for Photonicat power management MCU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240912075523.GB24460@google.com>
Date: Thu, 12 Sep 2024 08:55:23 +0100
From: Lee Jones <lee@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Junhao Xie <bigfoot@...ssfun.cn>, devicetree@...r.kernel.org,
	linux-hwmon@...r.kernel.org, linux-leds@...r.kernel.org,
	linux-pm@...r.kernel.org, linux-rtc@...r.kernel.org,
	linux-watchdog@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org,
	LKML <linux-kernel@...r.kernel.org>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Chukun Pan <amadeus@....edu.cn>, Conor Dooley <conor+dt@...nel.org>,
	Günter Röck <linux@...ck-us.net>,
	Heiko Stübner <heiko@...ech.de>,
	Jean Delvare <jdelvare@...e.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Pavel Machek <pavel@....cz>, Rob Herring <robh@...nel.org>,
	Sebastian Reichel <sre@...nel.org>,
	Wim Van Sebroeck <wim@...ux-watchdog.org>
Subject: Re: [PATCH 1/9] mfd: Add driver for Photonicat power management MCU

On Sun, 08 Sep 2024, Krzysztof Kozlowski wrote:

> On 07/09/2024 16:33, Junhao Xie wrote:
> > On 2024/9/7 16:44, Markus Elfring wrote:
> >> …
> >>> +++ b/include/linux/mfd/photonicat-pmu.h
> >>> @@ -0,0 +1,86 @@
> >> …
> >>> +#ifndef _PHOTONICAT_PMU_H
> >>> +#define _PHOTONICAT_PMU_H
> >> …
> >>
> >> I suggest to omit leading underscores from such identifiers.
> >> https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier
> >>
> >> Regards,
> >> Markus
> > 
> > Thanks for your suggestion, does this look better?
> > #ifndef MFD_PHOTONICAT_PMU_H
> > #define MFD_PHOTONICAT_PMU_H

Yes, this is better.

> <form letter>
> Feel free to ignore all comments from Markus, regardless whether the
> suggestion is reasonable or not. This person is banned from LKML and
> several maintainers ignore Markus' feedback, because it is just a waste
> of time.
> </form letter>

If you really _must_ do this, at least keep it factual.

To the best of my knowledge Markus is not banned from LKML.

-- 
Lee Jones [李琼斯]