linux-kernel - Re: [PATCH v1] ARM: dts: aspeed: yosemite4: Add power module and ADC on Medusa Board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4ad15ead271edd36d4638068cdf63b124a78b437.camel@codeconstruct.com.au>
Date: Thu, 12 Sep 2024 10:30:44 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>, Ricky CX Wu
	 <ricky.cx.wu.wiwynn@...il.com>
Cc: "Rob Herring (Arm)" <robh@...nel.org>, linux-aspeed@...ts.ozlabs.org, 
 linux-arm-kernel@...ts.infradead.org, patrick@...cx.xyz, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, Joel Stanley
 <joel@....id.au>
Subject: Re: [PATCH v1] ARM: dts: aspeed: yosemite4: Add power module and
 ADC on Medusa Board

Hi Ricky,

On Tue, 2024-09-10 at 09:15 -0500, Rob Herring (Arm) wrote:
> On Tue, 10 Sep 2024 15:53:56 +0800, Delphine CC Chiu wrote:
> > From: Ricky CX Wu <ricky.cx.wu.wiwynn@...il.com>
> > 
> > Add RTQ6056 as 2nd source ADC sensor on Medusa Board.
> > Add power sensors on Medusa board:
> > - Add XDP710 as 2nd source HSC to monitor P48V PSU power.
> > - Add MP5023 as P12V efuse (Driver exists but un-documented).
> > - Add PMBUS sensors as P12V Delta Module.
> > 
> > Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@...il.com>
> > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>
> > ---
> >  .../aspeed/aspeed-bmc-facebook-yosemite4.dts  | 45 ++++++++++++++++++-
> >  1 file changed, 43 insertions(+), 2 deletions(-)
> > 
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-facebook-yosemite4.dtb' for 20240910075357.3531211-1-Delphine_CC_Chiu@...ynn.com:
> 
> arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@...8a000/i2c@.../power-sensor@40: failed to match any schema with compatible: ['mps,mp5023']
> arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@...8a000/i2c@.../power-sensor@62: failed to match any schema with compatible: ['pmbus']
> arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@...8a000/i2c@.../power-sensor@64: failed to match any schema with compatible: ['pmbus']
> arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@...8a000/i2c@.../power-sensor@65: failed to match any schema with compatible: ['pmbus']
> arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@...8a000/i2c@.../power-sensor@68: failed to match any schema with compatible: ['pmbus']

Can you please either:

1. Drop these nodes so we're not adding more warnings, or
2. Write the appropriate bindings and send them in a v2?

Andrew