[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9a4377fe27d8eb940399e452b68fb5a6d678929f.camel@pengutronix.de>
Date: Thu, 12 Sep 2024 10:11:27 +0200
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Jerome Brunet <jbrunet@...libre.com>, Stephen Boyd <sboyd@...nel.org>,
Neil Armstrong <neil.armstrong@...aro.org>, Kevin Hilman
<khilman@...libre.com>, Martin Blumenstingl
<martin.blumenstingl@...glemail.com>, Jiucheng Xu <jiucheng.xu@...ogic.com>
Cc: linux-arm-kernel@...ts.infradead.org, linux-amlogic@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 0/9] reset: amlogic: move audio reset drivers out of
CCF
On Di, 2024-09-10 at 18:32 +0200, Jerome Brunet wrote:
> This patchset follows the discussion about having reset driver in the
> clock tree [1]. Ideally those should reside in the reset part of tree.
>
> Also the code of the amlogic reset driver is very similar between the 2
> trees and could use the same driver code.
>
> This patcheset alignes the reset drivers present in the reset and clock
> then adds support for the reset driver of audio clock controller found in
> the g12 and sm1 SoC family to the reset tree, using the auxiliary bus.
>
> The infrastructure put in place is meant to be generic enough so we may
> eventually also move the reset drivers in the meson8b and aoclk clock
> controllers.
>
> This was tested on sm1 vim3l and gxl aml-s905x-cc.
>
> Changes since v4 [6]:
> * Fix Kconfig depends and select as reported by Philipp and
> and 0-day robot.
>
> Changes since v3 [5]:
> * Drop pltf/platform as suggested
>
> Changes since v2 [4]:
> * Fix undefined read access of the reset register
> * Fix Kconfig symbol description
>
> Changes since v1 [3]:
> * Fixes formatting errors reported by Stephen.
> * Changed parameters type to unsigned
> * Fix usage of ops passed as parameters, previously ignored.
> * Return 0 instead of an error if reset support is absent
> to properly decouple from the clock and have a weak
> dependency
> * Split the platform and auxiliary modules in 2 distinct modules
> to fix the COMPILE_TEST error reported by ktest robot.
>
> Change since RFC [2]:
> * Move the aux registration helper out of clock too.
Thank you,
Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>
regards
Philipp
Powered by blists - more mailing lists