linux-kernel - [PATCH v2 4/5] drm/tegra: dpaux: Use IRQF_NO_AUTOEN flag in request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240912083020.3720233-5-ruanjinjie@huawei.com>
Date: Thu, 12 Sep 2024 16:30:19 +0800
From: Jinjie Ruan <ruanjinjie@...wei.com>
To: <laurentiu.palcu@....nxp.com>, <l.stach@...gutronix.de>,
	<maarten.lankhorst@...ux.intel.com>, <mripard@...nel.org>,
	<tzimmermann@...e.de>, <airlied@...il.com>, <daniel@...ll.ch>,
	<shawnguo@...nel.org>, <s.hauer@...gutronix.de>, <kernel@...gutronix.de>,
	<festevam@...il.com>, <p.zabel@...gutronix.de>, <robdclark@...il.com>,
	<sean@...rly.run>, <konradybcio@...nel.org>, <quic_abhinavk@...cinc.com>,
	<dmitry.baryshkov@...aro.org>, <marijn.suijten@...ainline.org>,
	<thierry.reding@...il.com>, <mperttunen@...dia.com>, <jonathanh@...dia.com>,
	<agx@...xcpu.org>, <gregkh@...uxfoundation.org>, <jordan@...micpenguin.net>,
	<dri-devel@...ts.freedesktop.org>, <imx@...ts.linux.dev>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-msm@...r.kernel.org>, <freedreno@...ts.freedesktop.org>,
	<linux-tegra@...r.kernel.org>
CC: <ruanjinjie@...wei.com>
Subject: [PATCH v2 4/5] drm/tegra: dpaux: Use IRQF_NO_AUTOEN flag in request_irq()

disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable when request IRQ.

Fixes: 9e532b3ad9a7 ("drm/tegra: dpaux: Disable interrupt when detached")
Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
---
 drivers/gpu/drm/tegra/dpaux.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c
index ae12d001a04b..9646dba950e0 100644
--- a/drivers/gpu/drm/tegra/dpaux.c
+++ b/drivers/gpu/drm/tegra/dpaux.c
@@ -517,7 +517,7 @@ static int tegra_dpaux_probe(struct platform_device *pdev)
 	pm_runtime_enable(&pdev->dev);
 	pm_runtime_get_sync(&pdev->dev);
 
-	err = devm_request_irq(dpaux->dev, dpaux->irq, tegra_dpaux_irq, 0,
+	err = devm_request_irq(dpaux->dev, dpaux->irq, tegra_dpaux_irq, IRQF_NO_AUTOEN,
 			       dev_name(dpaux->dev), dpaux);
 	if (err < 0) {
 		dev_err(dpaux->dev, "failed to request IRQ#%u: %d\n",
@@ -525,8 +525,6 @@ static int tegra_dpaux_probe(struct platform_device *pdev)
 		goto err_pm_disable;
 	}
 
-	disable_irq(dpaux->irq);
-
 	dpaux->aux.transfer = tegra_dpaux_transfer;
 	dpaux->aux.dev = &pdev->dev;
 
-- 
2.34.1