linux-kernel - Re: [PATCH] erofs: reject inodes with negative i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0600636f-ff01-4175-9de7-4a4fcf7e5669@kernel.org>
Date: Thu, 12 Sep 2024 17:08:54 +0800
From: Chao Yu <chao@...nel.org>
To: Gao Xiang <hsiangkao@...ux.alibaba.com>, linux-erofs@...ts.ozlabs.org
Cc: chao@...nel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] erofs: reject inodes with negative i_size

On 2024/9/12 16:35, Gao Xiang wrote:
> Negative i_size is never supported, although crafted images with inodes
> having negative i_size will not lead to security issues in our current
> codebase:
> 
> The following image can verify this (gzip+base64 encoded):
> 
> H4sICCmk4mYAA3Rlc3QuaW1nAGNgGAWjYBSMVPDo4dcH3jP2aTED2TwMKgxMUHHNJY/SQDQX
> LxcDIw3tZwXit44MDNpQ/n8gQJZ/vxjijosPuSyZ0DUDgQqcZoKzVYFsDShbHeh6PT29ktTi
> Eqz2g/y2pBFiLxDMh4lhs5+W4TAKRsEoGAWjYBSMglEwCkYBPQAAS2DbowAQAAA=
> 
> Mark as bad inodes for such corrupted inodes explicitly.
> 
> Signed-off-by: Gao Xiang <hsiangkao@...ux.alibaba.com>

Reviewed-by: Chao Yu <chao@...nel.org>

Thanks,