linux-kernel - Re: [PATCH 1/2] i2c: synquacer: Fix an error handling path in synquacer_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXFH+zB_YuUS+vaEpguhuVGLYbQw55VNDCxnBfSPe6b-nw@mail.gmail.com>
Date: Thu, 12 Sep 2024 12:22:51 +0200
From: Ard Biesheuvel <ardb@...nel.org>
To: Andi Shyti <andi.shyti@...nel.org>
Cc: Christophe JAILLET <christophe.jaillet@...adoo.fr>, 
	Andy Shevchenko <andy.shevchenko@...il.com>, Wolfram Sang <wsa@...nel.org>, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org, linux-i2c@...r.kernel.org
Subject: Re: [PATCH 1/2] i2c: synquacer: Fix an error handling path in synquacer_i2c_probe()

On Mon, 6 May 2024 at 11:03, Andi Shyti <andi.shyti@...nel.org> wrote:
>
> Hi Christophe,
>
> On Sat, Jan 06, 2024 at 01:48:24PM +0100, Christophe JAILLET wrote:
> > If an error occurs after the clk_prepare_enable() call, it should be undone
> > by a corresponding clk_disable_unprepare() call, as already done in the
> > remove() function.
> >
> > As devm_clk_get() is used, we can switch to devm_clk_get_enabled() to
> > handle it automatically and fix the probe.
> >
> > Update the remove() function accordingly and remove the now useless
> > clk_disable_unprepare() call.
> >
> > Fixes: 0d676a6c4390 ("i2c: add support for Socionext SynQuacer I2C controller")
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
>
> Applied to i2c/i2c-host-fixes.
>

These patches should be reverted: ACPI boot on SynQuacer based systems
now fails with

[    6.206022] synquacer_i2c SCX0003:00: error -ENOENT: failed to get
and enable clock
[    6.235762] synquacer_i2c SCX0003:00: probe with driver
synquacer_i2c failed with error -2

as in this case, there is no clock to enable, and the clock rate is
specified in the PRP0001 device node.