linux-kernel - Re: [PATCH] erofs: sunset unneeded NOFAILs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a7733831-2d1f-4197-9ca9-2ced86aca136@kernel.org>
Date: Thu, 12 Sep 2024 19:59:30 +0800
From: Chao Yu <chao@...nel.org>
To: Gao Xiang <hsiangkao@...ux.alibaba.com>, linux-erofs@...ts.ozlabs.org
Cc: chao@...nel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] erofs: sunset unneeded NOFAILs

On 2024/9/5 16:47, Gao Xiang wrote:
> With iterative development, our codebase can now deal with compressed
> buffer misses properly if both in-place I/O and compressed buffer
> allocation fail.
> 
> Note that if readahead fails (with non-uptodate folios), the original
> request will then fall back to synchronous read, and `.read_folio()`
> should return appropriate errnos; otherwise -EIO will be passed to
> user space, which is unexpected.
> 
> To simplify rarely encountered failure paths, a mimic decompression
> will be just used.  Before that, failure reasons are recorded in
> compressed_bvecs[] and they also act as placeholders to avoid in-place
> pages.  They will be parsed just before decompression and then pass
> back to `.read_folio()`.
> 
> Signed-off-by: Gao Xiang <hsiangkao@...ux.alibaba.com>

Reviewed-by: Chao Yu <chao@...nel.org>

Thanks,