[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <8e5364f8-eaa3-4f70-b298-70a21e716f90@quicinc.com>
Date: Thu, 12 Sep 2024 10:01:46 +0800
From: Lijuan Gao <quic_lijuang@...cinc.com>
To: Rob Herring <robh@...nel.org>
CC: Bjorn Andersson <andersson@...nel.org>,
Linus Walleij
<linus.walleij@...aro.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
"Conor
Dooley" <conor+dt@...nel.org>, <linux-arm-msm@...r.kernel.org>,
<linux-gpio@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <kernel@...cinc.com>
Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: document the QCS615 Top Level
Mode Multiplexer
在 9/11/2024 11:18 PM, Rob Herring 写道:
> On Tue, Sep 10, 2024 at 06:26:14PM +0800, Lijuan Gao wrote:
>> Document the Top Level Mode Multiplexer on the QCS615 Platform.
>> It concisely explains the pin multiplexing and configuration in
>> the device tree, and includes simple examples of typical device
>> tree snippets, making it easier for designers to configure and
>> manage chip pins.
>>
>> Signed-off-by: Lijuan Gao <quic_lijuang@...cinc.com>
>> ---
>> .../bindings/pinctrl/qcom,qcs615-tlmm.yaml | 123 +++++++++++++++++++++
>> 1 file changed, 123 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,qcs615-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,qcs615-tlmm.yaml
>> new file mode 100644
>> index 000000000000..2bfb0a453880
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,qcs615-tlmm.yaml
>> @@ -0,0 +1,123 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/pinctrl/qcom,qcs615-tlmm.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Technologies, Inc. QCS615 TLMM block
>> +
>> +maintainers:
>> + - Lijuan Gao <quic_lijuang@...cinc.com>
>> +
>> +description:
>> + Top Level Mode Multiplexer pin controller in Qualcomm QCS615 SoC.
>> +
>> +allOf:
>> + - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
>> +
>> +properties:
>> + compatible:
>> + const: qcom,qcs615-tlmm
>> +
>> + reg:
>> + maxItems: 3
>> +
>> + reg-names:
>> + items:
>> + - const: east
>> + - const: west
>> + - const: south
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> + gpio-reserved-ranges:
>> + minItems: 1
>> + maxItems: 62
>> +
>> + gpio-line-names:
>> + maxItems: 123
>> +
>> +patternProperties:
>> + "-state$":
>> + oneOf:
>> + - $ref: "#/$defs/qcom-qcs615-tlmm-state"
>> + - patternProperties:
>
> Needs 'type: object' before patternProperties.
> > Otherwise,
>
> Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
Well noted.
--
Thx and BRs
Lijuan Gao
Powered by blists - more mailing lists