linux-kernel - Re: [PATCH net-next v1 1/1] net: ks8851: use %*ph to print small buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240912120651.GL572255@kernel.org>
Date: Thu, 12 Sep 2024 13:06:51 +0100
From: Simon Horman <horms@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next v1 1/1] net: ks8851: use %*ph to print small
 buffer

On Wed, Sep 11, 2024 at 10:36:30PM +0300, Andy Shevchenko wrote:
> Use %*ph format to print small buffer as hex string.

Hi Andy,

Perhaps it would be worth mentioning that this patch
changes the output format such that there is a space
between each byte rather than each 32-bit word.

Or at least, that is what a local hack on my side indicated
things would look like :)

> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/net/ethernet/micrel/ks8851_common.c | 19 +------------------
>  1 file changed, 1 insertion(+), 18 deletions(-)
> 
> diff --git a/drivers/net/ethernet/micrel/ks8851_common.c b/drivers/net/ethernet/micrel/ks8851_common.c
> index 7fa1820db9cc..a07ffc53da64 100644
> --- a/drivers/net/ethernet/micrel/ks8851_common.c
> +++ b/drivers/net/ethernet/micrel/ks8851_common.c
> @@ -215,22 +215,6 @@ static void ks8851_init_mac(struct ks8851_net *ks, struct device_node *np)
>  	ks8851_write_mac_addr(dev);
>  }
>  
> -/**
> - * ks8851_dbg_dumpkkt - dump initial packet contents to debug
> - * @ks: The device state
> - * @rxpkt: The data for the received packet
> - *
> - * Dump the initial data from the packet to dev_dbg().
> - */
> -static void ks8851_dbg_dumpkkt(struct ks8851_net *ks, u8 *rxpkt)
> -{
> -	netdev_dbg(ks->netdev,
> -		   "pkt %02x%02x%02x%02x %02x%02x%02x%02x %02x%02x%02x%02x\n",
> -		   rxpkt[4], rxpkt[5], rxpkt[6], rxpkt[7],
> -		   rxpkt[8], rxpkt[9], rxpkt[10], rxpkt[11],
> -		   rxpkt[12], rxpkt[13], rxpkt[14], rxpkt[15]);
> -}
> -
>  /**
>   * ks8851_rx_pkts - receive packets from the host
>   * @ks: The device information.
> @@ -296,8 +280,7 @@ static void ks8851_rx_pkts(struct ks8851_net *ks, struct sk_buff_head *rxq)
>  
>  				ks->rdfifo(ks, rxpkt, rxalign + 8);
>  
> -				if (netif_msg_pktdata(ks))
> -					ks8851_dbg_dumpkkt(ks, rxpkt);
> +				netif_dbg(ks, pktdata, ks->netdev, "pkt %12ph\n", &rxpkt[4]);

nit: I would have line wrapped this so it is <= 80 columns wide.

>  
>  				skb->protocol = eth_type_trans(skb, ks->netdev);
>  				__skb_queue_tail(rxq, skb);
> -- 
> 2.43.0.rc1.1336.g36b5255a03ac
> 
>