linux-kernel - Re: [PATCH] selftests: Makefile: add missing 'net/lib' to targets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+FuTSeFg5AcSxdp4AKi4iPROF8r2dy2BhaMKpCrFD8FM3G=Ug@mail.gmail.com>
Date: Thu, 12 Sep 2024 09:13:30 -0400
From: Willem de Bruijn <willemb@...gle.com>
To: Anders Roxell <anders.roxell@...aro.org>
Cc: shuah@...nel.org, kuba@...nel.org, linux-kselftest@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Network Development <netdev@...r.kernel.org>, 
	Willem de Bruijn <willemdebruijn.kernel@...il.com>
Subject: Re: [PATCH] selftests: Makefile: add missing 'net/lib' to targets

On Thu, Sep 12, 2024 at 2:31 AM Anders Roxell <anders.roxell@...aro.org> wrote:
>
> Fixes: 1d0dc857b5d8 ("selftests: drv-net: add checksum tests")
> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>

This target is automatically built for targets that depend on it.

See the commit that introduced it, b86761ff6374.

+++ b/tools/testing/selftests/Makefile
@@ -116,6 +116,13 @@ TARGETS += zram
 TARGETS_HOTPLUG = cpu-hotplug
 TARGETS_HOTPLUG += memory-hotplug

+# Networking tests want the net/lib target, include it automatically
+ifneq ($(filter net,$(TARGETS)),)
+ifeq ($(filter net/lib,$(TARGETS)),)
+       INSTALL_DEP_TARGETS := net/lib
+endif
+endif

If you believe that it needs to be included directly, please expand
the commit message with the reasoning.