linux-kernel - Re: [PATCH] dt-bindings: serial: rs485: Fix rs485-rts-delay property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <172614785898.3201563.3996024318064999067.robh@kernel.org>
Date: Thu, 12 Sep 2024 08:30:59 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Michal Simek <michal.simek@....com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>, 
 monstr@...str.eu, Jiri Slaby <jirislaby@...nel.org>, git@...inx.com, 
 michal.simek@...inx.com, Benjamin Gaignard <benjamin.gaignard@...com>, 
 "open list:TTY LAYER AND SERIAL DRIVERS" <linux-serial@...r.kernel.org>, 
 Conor Dooley <conor+dt@...nel.org>, 
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: serial: rs485: Fix rs485-rts-delay
 property


On Thu, 12 Sep 2024 14:05:28 +0200, Michal Simek wrote:
> Code expects array only with 2 items which should be checked.
> But also item checking is not working as it should likely because of
> incorrect items description.
> 
> Fixes: d50f974c4f7f ("dt-bindings: serial: Convert rs485 bindings to json-schema")
> Signed-off-by: Michal Simek <michal.simek@....com>
> ---
> 
>  .../devicetree/bindings/serial/rs485.yaml     | 20 +++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/rs485.yaml: properties:rs485-rts-delay: {'description': 'prop-encoded-array <a b>', '$ref': '/schemas/types.yaml#/definitions/uint32-array', 'maxItems': 2, 'items': [{'description': 'Delay between rts signal and beginning of data sent in milliseconds. It corresponds to the delay before sending data.', 'default': 0, 'maximum': 50}, {'description': 'Delay between end of data sent and rts signal in milliseconds. It corresponds to the delay after sending data and actual release of the line.', 'default': 0, 'maximum': 100}]} should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/48055c01f7da7ba4e1592090d3bfedb0ac321bb0.1726142726.git.michal.simek@amd.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.