linux-kernel - Re: [PATCH] usb: gadget: core: force synchronous registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024091210-capitol-quartet-e3d5@gregkh>
Date: Thu, 12 Sep 2024 15:34:21 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: John Keeping <jkeeping@...usicbrands.com>
Cc: Roy Luo <royluo@...gle.com>, Alan Stern <stern@...land.harvard.edu>,
	yuan linyu <yuanlinyu@...onor.com>,
	Sumit Garg <sumit.garg@...aro.org>,
	Krishna Kurapati <quic_kriskura@...cinc.com>,
	Paul Cercueil <paul@...pouillou.net>,
	Chris Wulff <crwulff@...il.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: core: force synchronous registration

On Thu, Sep 12, 2024 at 02:16:07PM +0100, John Keeping wrote:
> Registering a gadget driver is expected to complete synchronously and
> immediately after calling driver_register() this function checks that
> the driver has bound so as to return an error.
> 
> Set PROBE_FORCE_SYNCHRONOUS to ensure this is the case even when
> asynchronous probing is set as the default.
> 
> Signed-off-by: John Keeping <jkeeping@...usicbrands.com>
> ---
>  drivers/usb/gadget/udc/core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
> index cf6478f97f4a3..a6f46364be65f 100644
> --- a/drivers/usb/gadget/udc/core.c
> +++ b/drivers/usb/gadget/udc/core.c
> @@ -1696,6 +1696,7 @@ int usb_gadget_register_driver_owner(struct usb_gadget_driver *driver,
>  	driver->driver.bus = &gadget_bus_type;
>  	driver->driver.owner = owner;
>  	driver->driver.mod_name = mod_name;
> +	driver->driver.probe_type = PROBE_FORCE_SYNCHRONOUS;

What commit id does this fix?

thanks,

greg k-h