linux-kernel - Re: [PATCH 06/13] media: i2c: imx214: Drop IMX214_REG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPybu_1oicaRO8L5XGCH7FbAyE8P3tGhTgRPntmCPwA+65_XKQ@mail.gmail.com>
Date: Thu, 12 Sep 2024 15:40:16 +0200
From: Ricardo Ribalda Delgado <ribalda@...nel.org>
To: git@...tzsch.eu
Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, ~postmarketos/upstreaming@...ts.sr.ht, 
	phone-devel@...r.kernel.org, linux-media@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/13] media: i2c: imx214: Drop IMX214_REG_EXPOSURE from
 mode reg arrays

On Mon, Sep 2, 2024 at 11:53 PM André Apitzsch via B4 Relay
<devnull+git.apitzsch.eu@...nel.org> wrote:
>
> From: André Apitzsch <git@...tzsch.eu>
>
> The IMX214_REG_EXPOSURE is configured twice, once with a hardcoded value
> in the mode_<res> registers arrays, and once via v4l2_ctrl_ops. The
> latter is enough, drop the former.
>
> Signed-off-by: André Apitzsch <git@...tzsch.eu>
Acked-by: Ricardo Ribalda <ribalda@...omium.org>

> ---
>  drivers/media/i2c/imx214.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
> index 91664e188fd0..4507e12dd4cd 100644
> --- a/drivers/media/i2c/imx214.c
> +++ b/drivers/media/i2c/imx214.c
> @@ -254,7 +254,6 @@ static const struct cci_reg_sequence mode_4096x2304[] = {
>         { CCI_REG8(0x3011), 0x00 },
>         { IMX214_REG_STATS_OUT_EN, IMX214_STATS_OUT_ON },
>
> -       { IMX214_REG_EXPOSURE, IMX214_EXPOSURE_DEFAULT },
>         { IMX214_REG_SHORT_EXPOSURE, 500 },
>
>         { IMX214_REG_ANALOG_GAIN, 0 },
> @@ -328,7 +327,6 @@ static const struct cci_reg_sequence mode_1920x1080[] = {
>         { CCI_REG8(0x3011), 0x00 },
>         { IMX214_REG_STATS_OUT_EN, IMX214_STATS_OUT_ON },
>
> -       { IMX214_REG_EXPOSURE, IMX214_EXPOSURE_DEFAULT },
>         { IMX214_REG_SHORT_EXPOSURE, 500 },
>
>         { IMX214_REG_ANALOG_GAIN, 0 },
>
> --
> 2.46.0
>
>