linux-kernel - Re: [PATCH] spi: ep93xx: update kerneldoc comments for ep93xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2bf46273a071cc90e3b33c08bbb0fad475b6e0ef.camel@gmail.com>
Date: Thu, 12 Sep 2024 15:45:11 +0200
From: Alexander Sverdlin <alexander.sverdlin@...il.com>
To: Arnd Bergmann <arnd@...nel.org>, Mark Brown <broonie@...nel.org>, Linus
 Walleij <linus.walleij@...aro.org>, Nikita Shubin
 <nikita.shubin@...uefel.me>, Arnd Bergmann <arnd@...db.de>
Cc: kernel test robot <lkp@...el.com>, Vinod Koul <vkoul@...nel.org>, 
	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: ep93xx: update kerneldoc comments for ep93xx_spi

On Thu, 2024-09-12 at 13:21 +0000, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Two fields got removed but are still documented:
> 
> drivers/spi/spi-ep93xx.c:98: warning: Excess struct member 'dma_rx_data' description in 'ep93xx_spi'
> drivers/spi/spi-ep93xx.c:98: warning: Excess struct member 'dma_tx_data' description in 'ep93xx_spi'
> 
> Fixes: 3cfe73256905 ("spi: ep93xx: add DT support for Cirrus EP93xx")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Alexander Sverdlin <alexander.sverdlin@...il.com>

> ---
> I've added this fixup in the ep93xx/dt-conversion branch
> 
>  drivers/spi/spi-ep93xx.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
> index ffbe0d522bce..dc6bdc74643d 100644
> --- a/drivers/spi/spi-ep93xx.c
> +++ b/drivers/spi/spi-ep93xx.c
> @@ -76,8 +76,6 @@
>   *              frame decreases this level and sending one frame increases it.
>   * @dma_rx: RX DMA channel
>   * @dma_tx: TX DMA channel
> - * @dma_rx_data: RX parameters passed to the DMA engine
> - * @dma_tx_data: TX parameters passed to the DMA engine
>   * @rx_sgt: sg table for RX transfers
>   * @tx_sgt: sg table for TX transfers
>   * @zeropage: dummy page used as RX buffer when only TX buffer is passed in by

-- 
Alexander Sverdlin.