linux-kernel - Re: [PATCH v4 07/30] riscv: zicfilp / zicfiss in dt-bindings (extensions.yaml)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <172618672393.1080888.11349502657556279668.robh@kernel.org>
Date: Thu, 12 Sep 2024 19:18:43 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Deepak Gupta <debug@...osinc.com>
Cc: andrii@...nel.org, peterz@...radead.org, guoren@...nel.org, 
 sunilvl@...tanamicro.com, paul.walmsley@...ive.com, 
 ben.dooks@...ethink.co.uk, broonie@...nel.org, david@...hat.com, 
 vbabka@...e.cz, schwab@...e.de, alexghiti@...osinc.com, bp@...en8.de, 
 palmer@...ive.com, leobras@...hat.com, jerry.shih@...ive.com, 
 palmer@...belt.com, oleg@...hat.com, sameo@...osinc.com, alx@...nel.org, 
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, 
 songshuaishuai@...ylab.org, x86@...nel.org, linux-fsdevel@...r.kernel.org, 
 zong.li@...ive.com, tglx@...utronix.de, samuel.holland@...ive.com, 
 evan@...osinc.com, hpa@...or.com, linux-mm@...ck.org, bgray@...ux.ibm.com, 
 zev@...ilderbeest.net, linux-riscv@...ts.infradead.org, namcaov@...il.com, 
 bjorn@...osinc.com, ebiederm@...ssion.com, xiao.w.wang@...el.com, 
 rppt@...nel.org, samitolvanen@...gle.com, devicetree@...r.kernel.org, 
 aou@...s.berkeley.edu, tanzhasanwork@...il.com, sorear@...tmail.com, 
 linux-kselftest@...r.kernel.org, anup@...infault.org, corbet@....net, 
 conor@...nel.org, kees@...nel.org, dawei.li@...ngroup.cn, 
 dave.hansen@...ux.intel.com, deller@....de, jszhang@...nel.org, 
 ke.zhao@...ngroup.cn, Liam.Howlett@...cle.com, puranjay@...nel.org, 
 cleger@...osinc.com, ancientmodern4@...il.com, willy@...radead.org, 
 libang.li@...group.com, yang.lee@...ux.alibaba.com, 
 quic_bjorande@...cinc.com, usama.anjum@...labora.com, costa.shul@...hat.com, 
 andy.chiu@...ive.com, ryan.roberts@....com, revest@...omium.org, 
 mchitale@...tanamicro.com, cuiyunhui@...edance.com, arnd@...db.de, 
 brauner@...nel.org, antonb@...storrent.com, lorenzo.stoakes@...cle.com, 
 shuah@...nel.org, mingo@...hat.com, catalin.marinas@....com, 
 osalvador@...e.de, greentime.hu@...ive.com, linux-arch@...r.kernel.org, 
 krzk+dt@...nel.org, bhe@...hat.com, ajones@...tanamicro.com, 
 quic_zhonhan@...cinc.com, akpm@...ux-foundation.org, charlie@...osinc.com, 
 atishp@...osinc.com
Subject: Re: [PATCH v4 07/30] riscv: zicfilp / zicfiss in dt-bindings
 (extensions.yaml)


On Thu, 12 Sep 2024 16:16:26 -0700, Deepak Gupta wrote:
> Make an entry for cfi extensions in extensions.yaml.
> 
> Signed-off-by: Deepak Gupta <debug@...osinc.com>
> ---
>  .../devicetree/bindings/riscv/extensions.yaml        | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/riscv/extensions.yaml:367:75: [error] missing starting space in comment (comments)
./Documentation/devicetree/bindings/riscv/extensions.yaml:368:13: [error] syntax error: expected <block end>, but found '<scalar>' (syntax)
./Documentation/devicetree/bindings/riscv/extensions.yaml:373:75: [error] missing starting space in comment (comments)
./Documentation/devicetree/bindings/riscv/extensions.yaml:374:13: [warning] wrong indentation: expected 10 but found 12 (indentation)

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/extensions.yaml: ignoring, error parsing file
make[2]: *** Deleting file 'Documentation/devicetree/bindings/riscv/extensions.example.dts'
Documentation/devicetree/bindings/riscv/extensions.yaml:368:13: did not find expected key
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/riscv/extensions.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/cpus.example.dtb: cpu@0: False schema does not allow {'clock-frequency': 0, 'compatible': ['sifive,rocket0', 'riscv'], 'device_type': ['cpu'], 'i-cache-block-size': 64, 'i-cache-sets': 128, 'i-cache-size': 16384, 'reg': [[0]], 'riscv,isa-base': ['rv64i'], 'riscv,isa-extensions': [1761635584, 1627415296], 'interrupt-controller': {'#interrupt-cells': 1, 'compatible': ['riscv,cpu-intc'], 'interrupt-controller': True}, '$nodename': ['cpu@0']}
	from schema $id: http://devicetree.org/schemas/riscv/cpus.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/cpus.example.dtb: cpu@0: Unevaluated properties are not allowed ('riscv,isa-base', 'riscv,isa-extensions' were unexpected)
	from schema $id: http://devicetree.org/schemas/riscv/cpus.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/cpus.example.dtb: cpu@1: False schema does not allow {'clock-frequency': 0, 'compatible': ['sifive,rocket0', 'riscv'], 'd-cache-block-size': 64, 'd-cache-sets': 64, 'd-cache-size': 32768, 'd-tlb-sets': 1, 'd-tlb-size': 32, 'device_type': ['cpu'], 'i-cache-block-size': 64, 'i-cache-sets': 64, 'i-cache-size': 32768, 'i-tlb-sets': 1, 'i-tlb-size': 32, 'mmu-type': ['riscv,sv39'], 'reg': [[1]], 'tlb-split': True, 'riscv,isa-base': ['rv64i'], 'riscv,isa-extensions': [1761635584, 1627416064, 1677746944], 'interrupt-controller': {'#interrupt-cells': 1, 'compatible': ['riscv,cpu-intc'], 'interrupt-controller': True}, '$nodename': ['cpu@1']}
	from schema $id: http://devicetree.org/schemas/riscv/cpus.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/cpus.example.dtb: cpu@1: Unevaluated properties are not allowed ('riscv,isa-base', 'riscv,isa-extensions' were unexpected)
	from schema $id: http://devicetree.org/schemas/riscv/cpus.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/cpus.example.dtb: cpu@0: False schema does not allow {'device_type': ['cpu'], 'reg': [[0]], 'compatible': ['riscv'], 'mmu-type': ['riscv,sv48'], 'riscv,isa-base': ['rv64i'], 'riscv,isa-extensions': [1761635584, 1627416064, 1677746944], 'interrupt-controller': {'#interrupt-cells': 1, 'interrupt-controller': True, 'compatible': ['riscv,cpu-intc']}, '$nodename': ['cpu@0']}
	from schema $id: http://devicetree.org/schemas/riscv/cpus.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/cpus.example.dtb: cpu@0: Unevaluated properties are not allowed ('riscv,isa-base', 'riscv,isa-extensions' were unexpected)
	from schema $id: http://devicetree.org/schemas/riscv/cpus.yaml#
./Documentation/devicetree/bindings/riscv/extensions.yaml:368:13: did not find expected key
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1432: dt_binding_check] Error 2
make: *** [Makefile:224: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240912231650.3740732-8-debug@rivosinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.