linux-kernel - Re: [PATCH net v2] net: xilinx: axienet: Schedule NAPI in two steps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+BGju58H3u6-Z_tZApjaMC+LB5XEocPbuTWK9owHyM4Q@mail.gmail.com>
Date: Fri, 13 Sep 2024 17:37:35 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Sean Anderson <sean.anderson@...ux.dev>
Cc: Radhey Shyam Pandey <radhey.shyam.pandey@....com>, "David S . Miller" <davem@...emloft.net>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, Michal Simek <michal.simek@....com>, 
	linux-kernel@...r.kernel.org, Robert Hancock <robert.hancock@...ian.com>, 
	Shannon Nelson <shannon.nelson@....com>
Subject: Re: [PATCH net v2] net: xilinx: axienet: Schedule NAPI in two steps

On Fri, Sep 13, 2024 at 4:57 PM Sean Anderson <sean.anderson@...ux.dev> wrote:
>
> As advised by Documentation/networking/napi.rst, masking IRQs after
> calling napi_schedule can be racy. Avoid this by only masking/scheduling
> if napi_schedule_prep returns true.
>
> Fixes: 9e2bc267e780 ("net: axienet: Use NAPI for TX completion path")
> Fixes: cc37610caaf8 ("net: axienet: implement NAPI and GRO receive")
> Signed-off-by: Sean Anderson <sean.anderson@...ux.dev>
> Reviewed-by: Shannon Nelson <shannon.nelson@....com>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>