linux-kernel - Re: [PATCH v4 01/30] mm: Introduce ARCH_HAS_USER_SHADOW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5cc36aa7-e064-42b3-b52e-fb471d99d338@gmail.com>
Date: Fri, 13 Sep 2024 10:51:04 -0500
From: Carlos Bilbao <carlos.bilbao.osdev@...il.com>
To: Deepak Gupta <debug@...osinc.com>, paul.walmsley@...ive.com,
 palmer@...ive.com, conor@...nel.org, linux-doc@...r.kernel.org,
 linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, linux-fsdevel@...r.kernel.org,
 linux-mm@...ck.org, linux-arch@...r.kernel.org,
 linux-kselftest@...r.kernel.org
Cc: corbet@....net, palmer@...belt.com, aou@...s.berkeley.edu,
 robh@...nel.org, krzk+dt@...nel.org, oleg@...hat.com, tglx@...utronix.de,
 mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org,
 hpa@...or.com, peterz@...radead.org, akpm@...ux-foundation.org,
 arnd@...db.de, ebiederm@...ssion.com, kees@...nel.org,
 Liam.Howlett@...cle.com, vbabka@...e.cz, lorenzo.stoakes@...cle.com,
 shuah@...nel.org, brauner@...nel.org, samuel.holland@...ive.com,
 andy.chiu@...ive.com, jerry.shih@...ive.com, greentime.hu@...ive.com,
 charlie@...osinc.com, evan@...osinc.com, cleger@...osinc.com,
 xiao.w.wang@...el.com, ajones@...tanamicro.com, anup@...infault.org,
 mchitale@...tanamicro.com, atishp@...osinc.com, sameo@...osinc.com,
 bjorn@...osinc.com, alexghiti@...osinc.com, david@...hat.com,
 libang.li@...group.com, jszhang@...nel.org, leobras@...hat.com,
 guoren@...nel.org, samitolvanen@...gle.com, songshuaishuai@...ylab.org,
 costa.shul@...hat.com, bhe@...hat.com, zong.li@...ive.com,
 puranjay@...nel.org, namcaov@...il.com, antonb@...storrent.com,
 sorear@...tmail.com, quic_bjorande@...cinc.com, ancientmodern4@...il.com,
 ben.dooks@...ethink.co.uk, quic_zhonhan@...cinc.com,
 cuiyunhui@...edance.com, yang.lee@...ux.alibaba.com, ke.zhao@...ngroup.cn,
 sunilvl@...tanamicro.com, tanzhasanwork@...il.com, schwab@...e.de,
 dawei.li@...ngroup.cn, rppt@...nel.org, willy@...radead.org,
 usama.anjum@...labora.com, osalvador@...e.de, ryan.roberts@....com,
 andrii@...nel.org, alx@...nel.org, catalin.marinas@....com,
 broonie@...nel.org, revest@...omium.org, bgray@...ux.ibm.com, deller@....de,
 zev@...ilderbeest.net, Rick Edgecombe <rick.p.edgecombe@...el.com>
Subject: Re: [PATCH v4 01/30] mm: Introduce ARCH_HAS_USER_SHADOW_STACK

On 9/12/24 18:16, Deepak Gupta wrote:

> From: Mark Brown <broonie@...nel.org>
>
> Since multiple architectures have support for shadow stacks and we need to
> select support for this feature in several places in the generic code
> provide a generic config option that the architectures can select.
>
> Suggested-by: David Hildenbrand <david@...hat.com>
> Acked-by: David Hildenbrand <david@...hat.com>
> Signed-off-by: Mark Brown <broonie@...nel.org>
> Reviewed-by: Rick Edgecombe <rick.p.edgecombe@...el.com>
> Reviewed-by: Deepak Gupta <debug@...osinc.com>
> Signed-off-by: Deepak Gupta <debug@...osinc.com>
> ---
>  arch/x86/Kconfig   | 1 +
>  fs/proc/task_mmu.c | 2 +-
>  include/linux/mm.h | 2 +-
>  mm/Kconfig         | 6 ++++++
>  4 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 007bab9f2a0e..320e1f411163 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1957,6 +1957,7 @@ config X86_USER_SHADOW_STACK
>  	depends on AS_WRUSS
>  	depends on X86_64
>  	select ARCH_USES_HIGH_VMA_FLAGS
> +	select ARCH_HAS_USER_SHADOW_STACK
>  	select X86_CET
>  	help
>  	  Shadow stack protection is a hardware feature that detects function
> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> index 5f171ad7b436..0ea49725f524 100644
> --- a/fs/proc/task_mmu.c
> +++ b/fs/proc/task_mmu.c
> @@ -984,7 +984,7 @@ static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma)
>  #ifdef CONFIG_HAVE_ARCH_USERFAULTFD_MINOR
>  		[ilog2(VM_UFFD_MINOR)]	= "ui",
>  #endif /* CONFIG_HAVE_ARCH_USERFAULTFD_MINOR */
> -#ifdef CONFIG_X86_USER_SHADOW_STACK
> +#ifdef CONFIG_ARCH_HAS_USER_SHADOW_STACK
>  		[ilog2(VM_SHADOW_STACK)] = "ss",
>  #endif
>  #ifdef CONFIG_64BIT
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 147073601716..e39796ea17db 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -346,7 +346,7 @@ extern unsigned int kobjsize(const void *objp);
>  #endif
>  #endif /* CONFIG_ARCH_HAS_PKEYS */
>  
> -#ifdef CONFIG_X86_USER_SHADOW_STACK
> +#ifdef CONFIG_ARCH_HAS_USER_SHADOW_STACK
>  /*
>   * VM_SHADOW_STACK should not be set with VM_SHARED because of lack of
>   * support core mm.
> diff --git a/mm/Kconfig b/mm/Kconfig
> index b72e7d040f78..3167be663bca 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -1263,6 +1263,12 @@ config IOMMU_MM_DATA
>  config EXECMEM
>  	bool
>  
> +config ARCH_HAS_USER_SHADOW_STACK
> +	bool
> +	help
> +	  The architecture has hardware support for userspace shadow call
> +          stacks (eg, x86 CET, arm64 GCS or RISC-V Zicfiss).
> +
>  source "mm/damon/Kconfig"


Reviewed-by: Carlos Bilbao <carlos.bilbao.osdev@...il.com>


>  
>  endmenu


Thanks, Carlos