linux-kernel - Re: [RFC PATCH for-next] pm: cpupower: rename raw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZuRpzN2OKHQ75GZW@rhfedora>
Date: Fri, 13 Sep 2024 12:35:24 -0400
From: "John B. Wyatt IV" <jwyatt@...hat.com>
To: Min-Hua Chen <minhuadotchen@...il.com>
Cc: skhan@...uxfoundation.org, jkacur@...hat.com,
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	shuah@...nel.org, trenn@...e.com
Subject: Re: [RFC PATCH for-next] pm: cpupower: rename raw_pylibcpupower.i

On Fri, Sep 13, 2024 at 06:55:19AM +0800, Min-Hua Chen wrote:
> AFAIK,
> raw_pylibcpupower.i is not a generated file, it is a interface file
> for swig.

That is correct. You can do more advanced things to help SWIG handle
different languages, but so far with the script I wrote for libcpupower
simply copying the definition files as worked for me for the .i file.

See:
https://www.swig.org/Doc4.2/Preprocessor.html#Preprocessor

> The *.i file extension is also used for pre-processor output
> (single target build) and all *.i files are removed by 'make mrproper',
> including raw_pylibcpupower.i (should not be removed).

That would explain it. Not just 'make mrproper', but 'make clean'
in the root removes the file as well. 'make clean' in the tools
directory does not affect it.

>From 'man gcc':

       file.i
           C source code that should not be preprocessed.

> >
> >> I have reviewed and tested and this. I am good with it being a stopgap.
> >
> >I am okay with the stopgap, but I do want i explore other solutions.

Reviewing the documentation a better solution would be to rename it to .swg

'''
5.1.1 Input format

As input, SWIG expects a file containing ISO C/C++ declarations and special
SWIG directives. More often than not, this is a special SWIG interface file
which is usually denoted with a special .i or .swg suffix.
'''

https://www.swig.org/Doc4.2/SWIG.html

-- 
Sincerely,
John Wyatt
Software Engineer, Core Kernel
Red Hat