linux-kernel - Re: [PATCH v2 for-next] pm: cpupower: rename raw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e35af04e-a8ee-42e2-a2e0-c369a118044b@linuxfoundation.org>
Date: Fri, 13 Sep 2024 10:48:41 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: "John B. Wyatt IV" <jwyatt@...hat.com>,
 Min-Hua Chen <minhuadotchen@...il.com>
Cc: Thomas Renninger <trenn@...e.com>, Shuah Khan <shuah@...nel.org>,
 John Kacur <jkacur@...hat.com>, "John B . Wyatt IV"
 <sageofredondo@...il.com>, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2 for-next] pm: cpupower: rename raw_pylibcpupower.i

On 9/13/24 10:38, John B. Wyatt IV wrote:
> On Fri, Sep 13, 2024 at 07:01:00AM +0800, Min-Hua Chen wrote:
> 
>> To fix it, rename raw_pylibcpupower.i to raw_pylibcpupower.if.
> 
> Would you please rename this to .swg instead?
> 
> '''
> 5.1.1 Input format
> 
> As input, SWIG expects a file containing ISO C/C++ declarations and special
> SWIG directives. More often than not, this is a special SWIG interface file
> which is usually denoted with a special .i or .swg suffix.
> '''
> 
> https://www.swig.org/Doc4.2/SWIG.html
> 
> I tested it and .swg is not removed by 'make clean' or 'make mrproper'.

That is expected.

.i extension is used for a C pre-processor out, hence the need to
mrprpoer and clean remove it. Because of that reason, using .i
will not work for swig interface files.

We build files to debug problems and to check the pre-processor
output. So changing mrproper and cleans to not remove .i would
leave the tree dirty.

This is the reason why I wanted to understand the problem to come up
with a solutions than renaming the file with .if extension.

Please add this information to the changelog so it is clear that
.i extenion will not work for swig files that get added to kernel repos.

> 
> My apologies for the extra work Min-Hua. I can send a quick patch
> instead if you wish.
> 

+1 - Yes please send me the patch with renaming it with .swg extension.

thanks,
-- Shuah