linux-kernel - RE: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio pca9506 for CPLD IOE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TYZPR04MB5853062387962EB4CA08A366D6652@TYZPR04MB5853.apcprd04.prod.outlook.com>
Date: Fri, 13 Sep 2024 03:26:47 +0000
From: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@...ynn.com>
To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@...ynn.com>, Andrew Jeffery
	<andrew@...econstruct.com.au>, "patrick@...cx.xyz" <patrick@...cx.xyz>, Rob
 Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>
CC: Ricky CX Wu <ricky.cx.wu.wiwynn@...il.com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio pca9506 for
 CPLD IOE



> -----Original Message-----
> From: Delphine_CC_Chiu/WYHQ/Wiwynn
> Sent: Friday, September 13, 2024 10:08 AM
> To: Andrew Jeffery <andrew@...econstruct.com.au>;
> Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@...ynn.com>;
> patrick@...cx.xyz; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski
> <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Joel Stanley
> <joel@....id.au>
> Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@...il.com>;
> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> linux-aspeed@...ts.ozlabs.org; linux-kernel@...r.kernel.org
> Subject: RE: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio pca9506
> for CPLD IOE
> 
> 
> 
> > -----Original Message-----
> > From: Andrew Jeffery <andrew@...econstruct.com.au>
> > Sent: Thursday, September 12, 2024 10:11 AM
> > To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@...ynn.com>;
> > patrick@...cx.xyz; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski
> > <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Joel Stanley
> > <joel@....id.au>
> > Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@...il.com>;
> > devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> > linux-aspeed@...ts.ozlabs.org; linux-kernel@...r.kernel.org
> > Subject: Re: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio
> > pca9506 for CPLD IOE
> >
> >  [External Sender]
> >
> >  [External Sender]
> >
> > On Tue, 2024-09-10 at 13:47 +0800, Delphine CC Chiu wrote:
> > > From: Ricky CX Wu <ricky.cx.wu.wiwynn@...il.com>
> > >
> > > We use CPLD to emulate gpio pca9506 I/O expander on each server
> > > boards.
> > > Therefore, add pca9506 to probe driver for the CPLD I/O expander.
> >
> > I think it might be best if you add your own compatible to the list in
> > the gpio-pca95xx binding just in case there are some behavioural
> > quirks of your CPLD implementation? Not sure if this should be
> > "facebook,pca9506" or "wywinn,pca9506", but assuming facebook, from
> > there you can specify
> >
> >     compatible = "facebook,pca9506", "nxp,pca9506";
> >
> > This allows you to add the quirks to the driver as required in the
> > future through the more-specific compatible.
> >
> > Andrew
> 
> Hi Andrew,
> 
> Thanks for the review.
> I'll add the "facebook,pca9506" in gpio-pca95xx binding in next version of
> patches.

Hi Andrew,

I tried to add "facebook,pca9506" in the compatible list of gpio-pca95xx binding
and add compatible = "facebook,pca9506", "nxp,pca9506" but got following failed
messages:
    gpio@21: compatible: 'oneOf' conditional failed, one must be fixed:
        ['facebook,pca9506', 'nxp,pca9506'] is too long
        'diodes,pi4ioe5v6534q' was expected
        'nxp,pcal6534' was expected
        from schema $id: http://devicetree.org/schemas/gpio/gpio-pca95xx.yaml#
Would like to ask do you have any suggestions? Thanks.