linux-kernel - Re: [PATCH next] dmaengine: ep93xx: Fix a NULL vs IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <de829772e1928cb5707fdae9cb72fe5885216db7.camel@gmail.com>
Date: Fri, 13 Sep 2024 19:39:10 +0200
From: Alexander Sverdlin <alexander.sverdlin@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>, Nikita Shubin
	 <nikita.shubin@...uefel.me>
Cc: Vinod Koul <vkoul@...nel.org>, Arnd Bergmann <arnd@...db.de>, 
	dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] dmaengine: ep93xx: Fix a NULL vs IS_ERR() check in
 probe()

Hi Dan,

thanks for fixing this!

On Fri, 2024-09-13 at 17:35 +0300, Dan Carpenter wrote:
> This was intended to be an IS_ERR() check, not a NULL check.  The
> ep93xx_dma_of_probe() function doesn't return NULL pointers.
> 
> Fixes: 4e8ad5ed845b ("dmaengine: cirrus: Convert to DT for Cirrus EP93xx")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Alexander Sverdlin <alexander.sverdlin@...il.com>

> ---
>  drivers/dma/ep93xx_dma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
> index d084bd123c1c..ca86b2b5a913 100644
> --- a/drivers/dma/ep93xx_dma.c
> +++ b/drivers/dma/ep93xx_dma.c
> @@ -1504,7 +1504,7 @@ static int ep93xx_dma_probe(struct platform_device *pdev)
>  	int ret;
>  
>  	edma = ep93xx_dma_of_probe(pdev);
> -	if (!edma)
> +	if (IS_ERR(edma))
>  		return PTR_ERR(edma);
>  
>  	dma_dev = &edma->dma_dev;

-- 
Alexander Sverdlin.