linux-kernel - Re: [PATCH 1/3] Drivers: hv: vmbus: Disable Suspend-to-Idle for VMBus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202409140137.5jZxplAp-lkp@intel.com>
Date: Sat, 14 Sep 2024 01:43:10 +0800
From: kernel test robot <lkp@...el.com>
To: Erni Sri Satya Vennela <ernis@...ux.microsoft.com>, kys@...rosoft.com,
	haiyangz@...rosoft.com, wei.liu@...nel.org, decui@...rosoft.com,
	jikos@...nel.org, bentiss@...nel.org, dmitry.torokhov@...il.com,
	linux-hyperv@...r.kernel.org, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, ernis@...rosoft.com,
	Erni Sri Satya Vennela <ernis@...ux.microsoft.com>,
	Saurabh Sengar <ssengar@...ux.microsoft.com>
Subject: Re: [PATCH 1/3] Drivers: hv: vmbus: Disable Suspend-to-Idle for VMBus

Hi Erni,

kernel test robot noticed the following build errors:

[auto build test ERROR on hid/for-next]
[also build test ERROR on dtor-input/next dtor-input/for-linus linus/master v6.11-rc7 next-20240913]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Erni-Sri-Satya-Vennela/Drivers-hv-vmbus-Disable-Suspend-to-Idle-for-VMBus/20240913-053127
base:   https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next
patch link:    https://lore.kernel.org/r/1726176470-13133-2-git-send-email-ernis%40linux.microsoft.com
patch subject: [PATCH 1/3] Drivers: hv: vmbus: Disable Suspend-to-Idle for VMBus
config: i386-randconfig-003-20240913 (https://download.01.org/0day-ci/archive/20240914/202409140137.5jZxplAp-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240914/202409140137.5jZxplAp-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409140137.5jZxplAp-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/hv/vmbus_drv.c:985:27: error: 'vmbus_freeze' undeclared here (not in a function); did you mean 'vmbus_remove'?
     985 |         .suspend_noirq  = vmbus_freeze,
         |                           ^~~~~~~~~~~~
         |                           vmbus_remove


vim +985 drivers/hv/vmbus_drv.c

   973	
   974	/*
   975	 * Note: we must use the "noirq" ops: see the comment before vmbus_bus_pm.
   976	 *
   977	 * suspend_noirq/resume_noirq are set to NULL to support Suspend-to-Idle: we
   978	 * shouldn't suspend the vmbus devices upon Suspend-to-Idle, otherwise there
   979	 * is no way to wake up a Generation-2 VM.
   980	 *
   981	 * The other 4 ops are for hibernation.
   982	 */
   983	
   984	static const struct dev_pm_ops vmbus_pm = {
 > 985		.suspend_noirq  = vmbus_freeze,
   986		.resume_noirq	= NULL,
   987		.freeze_noirq	= vmbus_suspend,
   988		.thaw_noirq	= vmbus_resume,
   989		.poweroff_noirq	= vmbus_suspend,
   990		.restore_noirq	= vmbus_resume,
   991	};
   992	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki