[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240913-overarch-preplan-c899f16a90c8@spud>
Date: Fri, 13 Sep 2024 19:27:29 +0100
From: Conor Dooley <conor@...nel.org>
To: Vasileios Amoiridis <vassilisamir@...il.com>
Cc: jic23@...nel.org, lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, andriy.shevchenko@...ux.intel.com,
ang.iglesiasg@...il.com, linus.walleij@...aro.org,
biju.das.jz@...renesas.com, javier.carrasco.cruz@...il.com,
semen.protsenko@...aro.org, 579lpy@...il.com, ak@...klinger.de,
linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, christophe.jaillet@...adoo.fr
Subject: Re: [PATCH v6 2/4] dt-bindings: iio: pressure: bmp085: Add
interrupts for BMP3xx and BMP5xx devices
On Fri, Sep 13, 2024 at 01:32:32AM +0200, Vasileios Amoiridis wrote:
> Add interrupt options for BMP3xx and BMP5xx devices as well.
>
> Signed-off-by: Vasileios Amoiridis <vassilisamir@...il.com>
> ---
> .../bindings/iio/pressure/bmp085.yaml | 22 ++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> index 6fda887ee9d4..7c9d85be9008 100644
> --- a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> +++ b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> @@ -48,14 +48,34 @@ properties:
>
> interrupts:
> description:
> - interrupt mapping for IRQ (BMP085 only)
> + interrupt mapping for IRQ. Supported in BMP085, BMP3xx, BMP5xx
If you respin, you can drop the description entirely, since you've added
proper enforcement below.
Otherwise,
Acked-by: Conor Dooley <conor.dooley@...rochip.com>
Cheers,
Conor.
> maxItems: 1
>
> + drive-open-drain:
> + description:
> + set if the interrupt pin should be configured as open drain.
> + If not set, defaults to push-pull configuration.
> + type: boolean
> +
> required:
> - compatible
> - vddd-supply
> - vdda-supply
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + not:
> + contains:
> + enum:
> + - bosch,bmp085
> + - bosch,bmp380
> + - bosch,bmp580
> + then:
> + properties:
> + interrupts: false
> +
> additionalProperties: false
>
> examples:
> --
> 2.25.1
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists