linux-kernel - Re: [PATCH v1 3/6] misc: eeprom: eeprom_93cx6: Replace printk(KERN_ERR ...) with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZuSR4WXoD_2Mb8BI@smile.fi.intel.com>
Date: Fri, 13 Sep 2024 22:26:25 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Parker Newman <parker@...est.io>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jirislaby@...nel.org>, Arnd Bergmann <arnd@...db.de>,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	Parker Newman <pnewman@...necttech.com>
Subject: Re: [PATCH v1 3/6] misc: eeprom: eeprom_93cx6: Replace
 printk(KERN_ERR ...) with pr_err()

On Fri, Sep 13, 2024 at 03:12:28PM -0400, Parker Newman wrote:
> On Fri, 13 Sep 2024 20:54:05 +0300
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> > On Fri, Sep 13, 2024 at 10:55:40AM -0400, Parker Newman wrote:

...

> > if you go with pr_fmt() perhaps it still makes sense to have separate changes.
> > I dunno which one is better, up to you.
> 
> Sorry if I am miss-reading but do you mean the pr_err() and pr_fmt() can be combined
> and the read_poll_timeout() change should be made in a separate patch after?

Possibly, I dunno.

> Or should I be adding the pr_fmt() define in its own patch, followed by the pr_err()
> and read_poll_timeout() in a patch?

No, either altogether, or one patch for pr_err() + pr_fmt() and one for
read_poll_timeout().

-- 
With Best Regards,
Andy Shevchenko