linux-kernel - Re: [PATCH V22 08/22] mmc: sdhci: add UHS-II related definitions in headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <014449ba-6b9d-4fb3-8dda-4cbdfa74b9be@web.de>
Date: Fri, 13 Sep 2024 22:00:10 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Akashi Takahiro <takahiro.akashi@...aro.org>,
 Ben Chuang <ben.chuang@...esyslogic.com.tw>,
 Victor Shih <victor.shih@...esyslogic.com.tw>, linux-mmc@...r.kernel.org,
 Adrian Hunter <adrian.hunter@...el.com>, Ulf Hansson <ulf.hansson@...aro.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Ben Chuang <benchuanggli@...il.com>,
 Daniil Lunev <dlunev@...omium.org>, Greg Tu <greg.tu@...esyslogic.com.tw>,
 HL.Liu@...esyslogic.com.tw, Lucas Lai <Lucas.Lai@...esyslogic.com.tw>
Subject: Re: [PATCH V22 08/22] mmc: sdhci: add UHS-II related definitions in
 headers

…
> +++ b/drivers/mmc/host/sdhci-uhs2.h
> @@ -0,0 +1,177 @@
…
> +#ifndef __SDHCI_UHS2_H
> +#define __SDHCI_UHS2_H
…

I suggest to omit leading underscores from such identifiers.
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

Regards,
Markus