linux-kernel - Re: [PATCH v3 for-next] pm: cpupower: rename raw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4e064b13-2473-4a65-a0a1-94f0edb36432@linuxfoundation.org>
Date: Fri, 13 Sep 2024 14:32:39 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Min-Hua Chen <minhuadotchen@...il.com>, Thomas Renninger
 <trenn@...e.com>, Shuah Khan <shuah@...nel.org>,
 "John B. Wyatt IV" <jwyatt@...hat.com>, John Kacur <jkacur@...hat.com>
Cc: "John B . Wyatt IV" <sageofredondo@...il.com>, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v3 for-next] pm: cpupower: rename raw_pylibcpupower.i

On 9/13/24 14:17, Min-Hua Chen wrote:
> The raw_pylibcpupower.i is removed unexpectedly after 'make mrproper'
> 
> We can reproduce the error by performing the following steps:
> cd linux-next
> make mrproper
> cd tools/power/cpupower/bindings/python
> make
> 
> We will get an error message:
> make: *** No rule to make target 'raw_pylibcpupower.i', needed by 'raw_pylibcpupower_wrap.c'.  Stop.
> 
> The root cause:
> 
> The *.i files are already used for pre-processor output files and
> the kernel removes all the *.i files by 'make mrproper'.
> 
> That explains why the raw_pylibcpupower.i is removed by 'make mrproper'.
> 
> To fix it, Follow John's suggestion to rename raw_pylibcpupower.i to
> raw_pylibcpupower.swg.
> 
> See:
> https://www.swig.org/Doc4.2/SWIG.html
> 
> Reviewed-by: John B. Wyatt IV <jwyatt@...hat.com>
> Reviewed-by: John B. Wyatt IV <sageofredondo@...il.com>
> Tested-by: John B. Wyatt IV <jwyatt@...hat.com>
> Tested-by: John B. Wyatt IV <sageofredondo@...il.com>
> Signed-off-by: Min-Hua Chen <minhuadotchen@...il.com>
> 
> ---
> 
> change since v1:
> build a non-frc patch
> change since v2:
> follow the document to rename *.if to *.swg
> 

Thank you Min for finding the problem and working with us
to fix it.

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/log/?h=cpupower

Please note that this will be sent to PM maintainer in my next pull
request. This might be after the merge window.

thanks,
-- Shuah