linux-kernel - Re: [PATCH v2] firmware: coreboot: Don't register a pdev if screen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <87h6aj6xgk.fsf@minerva.mail-host-address-is-not-set>
Date: Fri, 13 Sep 2024 23:43:55 +0200
From: Javier Martinez Canillas <javierm@...hat.com>
To: Julius Werner <jwerner@...omium.org>
Cc: linux-kernel@...r.kernel.org, chrome-platform@...ts.linux.dev,
 intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, Hugues
 Bruant <hugues.bruant@...il.com>, Julius Werner <jwerner@...omium.org>,
 Brian Norris <briannorris@...omium.org>, Thomas Zimmermann
 <tzimmermann@...e.de>, Borislav Petkov <bp@...en8.de>, Tzung-Bi Shih
 <tzungbi@...nel.org>
Subject: Re: [PATCH v2] firmware: coreboot: Don't register a pdev if
 screen_info data is present

Julius Werner <jwerner@...omium.org> writes:

Hello Julius,

>> +       /*
>> +        * On Coreboot systems, the advertised LB_TAG_FRAMEBUFFER entry
>> +        * in the Coreboot table should only be used if the payload did
>> +        * not pass a framebuffer information to the Linux kernel.
>
> nit: The official brand spelling is "coreboot", always lowercase (even
> at the start of a sentence). Not a big deal though.
>
> Reviewed-by: Julius Werner <jwerner@...omium.org>
>

Thanks for pointing that out, I wasn't aware. I just posted a v3 with
the proper coreboot spelling and your Reviewed-by tag collected.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat