linux-kernel - Re: [PATCH v1 1/2] uio: uio_dmem_genirq: Make use of irq_get_trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240913235559.GA33362@vamoiridPC>
Date: Sat, 14 Sep 2024 01:55:59 +0200
From: Vasileios Amoiridis <vassilisamir@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Vasileios Amoiridis <vassilisamir@...il.com>,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] uio: uio_dmem_genirq: Make use of
 irq_get_trigger_type()

On Fri, Sep 13, 2024 at 12:40:09PM +0300, Andy Shevchenko wrote:
> On Fri, Sep 13, 2024 at 01:59:24AM +0200, Vasileios Amoiridis wrote:
> > Convert the following case:
> > 
> >         struct irq_data *irq_data = irq_get_irq_data(irq);
> > 
> >         if (irq_data && irqd_get_trigger_type(irq_data) ... ) {
> >                 ...
> >         }
> > 
> > to the simpler:
> > 
> >         if (irq_get_trigger_type(irq) ... ) {
> >                 ...
> >         }
> > 
> > by using the irq_get_trigger_type() function.
> 
> Btw, can you add a coccinelle ruleset for this?
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

Hi Andy!

Thanks for the time for the review! Yes, I would like to try it.

Cheers,
Vasilis