linux-kernel - Re: [PATCH bpf-next v2] selftests/bpf: convert test_xdp_features.sh to test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240913072658.GR572255@kernel.org>
Date: Fri, 13 Sep 2024 08:26:58 +0100
From: Simon Horman <horms@...nel.org>
To: Alexis Lothoré <alexis.lothore@...tlin.com>
Cc: Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	Andrii Nakryiko <andrii@...nel.org>,
	Martin KaFai Lau <martin.lau@...ux.dev>,
	Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>,
	Yonghong Song <yonghong.song@...ux.dev>,
	John Fastabend <john.fastabend@...il.com>,
	KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>,
	Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
	Mykola Lysenko <mykolal@...com>, Shuah Khan <shuah@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>,
	Jesper Dangaard Brouer <hawk@...nel.org>,
	Lorenzo Bianconi <lorenzo@...nel.org>,
	Maxime Chevallier <maxime.chevallier@...tlin.com>,
	ebpf@...uxfoundation.org,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	linux-kernel@...r.kernel.org, bpf@...r.kernel.org,
	linux-kselftest@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next v2] selftests/bpf: convert test_xdp_features.sh
 to test_progs

On Thu, Sep 12, 2024 at 10:17:13PM +0200, Alexis Lothoré wrote:
> Hi Simon,
> 
> On 9/11/24 16:18, Simon Horman wrote:
> 
> [...]
> 
> >> diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_features.c b/tools/testing/selftests/bpf/prog_tests/xdp_features.c
> >> new file mode 100644
> >> index 000000000000..bcb36a2d2767
> >> --- /dev/null
> >> +++ b/tools/testing/selftests/bpf/prog_tests/xdp_features.c
> >> @@ -0,0 +1,446 @@
> >> +// SPDX-License-Identifier: GPL-2.0
> >> +
> >> +/**
> >> + * Test XDP features
> >> + *
> >> + * Sets up a veth pair, and for each xdp feature under test:
> >> + * - asks the tested interface its xdp capabilities through bpf_xdp_query
> >> + * - attach and run some specific programs on both interfaces to check if
> >> + *   announced capability is respected
> >> + */
> > 
> > Hi Alexis,
> > 
> > This is neither a full review nor an issue that needs to block progress.
> > But, FWIIW, the comment above is not a Kernel doc, yet starts with '/**'.
> > I suggest that it should start with '/*' instead.
> 
> ACK. I'll wait for more comments on the series, and add the fix to the
> corresponding revision, if any.

Thanks, much appreciated.