[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <c9bda67d-ec94-48d7-b71f-de2b57b239d4@app.fastmail.com>
Date: Fri, 13 Sep 2024 07:35:33 +0000
From: "Arnd Bergmann" <arnd@...db.de>
To: arturs.artamonovs@...log.com, "Catalin Marinas" <catalin.marinas@....com>,
"Will Deacon" <will@...nel.org>, "Greg Malysa" <greg.malysa@...esys.com>,
"Philipp Zabel" <p.zabel@...gutronix.de>, "Rob Herring" <robh@...nel.org>,
"Krzysztof Kozlowski" <krzk+dt@...nel.org>,
"Conor Dooley" <conor+dt@...nel.org>,
"Utsav Agarwal" <Utsav.Agarwal@...log.com>,
"Michael Turquette" <mturquette@...libre.com>,
"Stephen Boyd" <sboyd@...nel.org>,
"Linus Walleij" <linus.walleij@...aro.org>,
"Bartosz Golaszewski" <brgl@...ev.pl>,
"Thomas Gleixner" <tglx@...utronix.de>, "Andi Shyti" <andi.shyti@...nel.org>,
"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
"Jiri Slaby" <jirislaby@...nel.org>, "Olof Johansson" <olof@...om.net>,
soc@...nel.org
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, linux-clk@...r.kernel.org,
"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
linux-i2c@...r.kernel.org, linux-serial@...r.kernel.org,
adsp-linux@...log.com,
"Nathan Barrett-Morrison" <nathan.morrison@...esys.com>
Subject: Re: [PATCH 06/21] include: dt-binding: clock: add adi clock header file
On Thu, Sep 12, 2024, at 18:24, Arturs Artamonovs via B4 Relay wrote:
> From: Arturs Artamonovs <arturs.artamonovs@...log.com>
>
> Add adi clock driver header file
Are you sure this is necessary? If the clk controller follows
a logical structure, it's usually easier to identify individual
clks by the way the hardware is laid out.
> +#ifndef DT_BINDINGS_CLOCK_ADI_SC5XX_CLOCK_H
> +#define DT_BINDINGS_CLOCK_ADI_SC5XX_CLOCK_H
> +
> +#define ADSP_SC598_CLK_DUMMY 0
> +#define ADSP_SC598_CLK_SYS_CLKIN0 1
> +#define ADSP_SC598_CLK_SYS_CLKIN1 2
> +#define ADSP_SC598_CLK_CGU0_PLL_IN 3
> +#define ADSP_SC598_CLK_CGU0_VCO_OUT 4
Unlike the DT compatible strings, these #defines don't have
to be specific to a particular SoC, you could just reuse them
for a family of chips even if they each use a slightly different
subset. Maybe name them "ADSP_CLK_*" or "ADSP_SC5XX_CLK_*"?
> +#define ADSP_SC598_CLK_END 80
This should not be part of the binding, in particular you
probably want to be able to extend this in order to support
additional chips.
Arnd
Powered by blists - more mailing lists