linux-kernel - [PATCH 0/6] EDITME: blk: refactor queue affinity helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240913-refactor-blk-affinity-helpers-v1-0-8e058f77af12@suse.de>
Date: Fri, 13 Sep 2024 09:41:58 +0200
From: Daniel Wagner <wagi@...nel.org>
To: Jens Axboe <axboe@...nel.dk>, Bjorn Helgaas <bhelgaas@...gle.com>, 
 "Michael S. Tsirkin" <mst@...hat.com>, Jason Wang <jasowang@...hat.com>, 
 "Martin K. Petersen" <martin.petersen@...cle.com>, 
 Keith Busch <kbusch@...nel.org>, Christoph Hellwig <hch@....de>, 
 Sagi Grimberg <sagi@...mberg.me>
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, 
 linux-pci@...r.kernel.org, virtualization@...ts.linux.dev, 
 linux-scsi@...r.kernel.org, megaraidlinux.pdl@...adcom.com, 
 mpi3mr-linuxdrv.pdl@...adcom.com, MPT-FusionLinux.pdl@...adcom.com, 
 storagedev@...rochip.com, linux-nvme@...ts.infradead.org, 
 Daniel Wagner <dwagner@...e.de>, 
 20240912-do-not-overwrite-pci-mapping-v1-1-85724b6cec49@...e.de, 
 Ming Lei <ming.lei@...hat.com>
Subject: [PATCH 0/6] EDITME: blk: refactor queue affinity helpers

These patches were part of 'honor isolcpus configuration' [1] series. To
simplify the review process I decided to send this as separate series
because I think it's a nice cleanup independent of the isolcpus feature.

One thing which I am a bit unsure are the CONFIG bits. I've reused the
BLK_MQ_PCI and BLK_MQ_VIRTIO as guard for the new helpers but it looks a
bit off.

changes:
  - renamed blk_mq_dev_map_queues to blk_mq_hctx_map_queues
  - squased 'virito: add APIs for retrieving vq affinity' into
    'blk-mq: introduce blk_mq_hctx_map_queues'
  - moved hisi_sas changed into a new patch
  - hisi_sas use define instead of hard coded value
  - moved helpers into their matching subsystem, removed
    blk-mq-pci and blk-mq-virtio files
  - fix spelling/typos
  - fixed long lines in docu (yep new lines in brief descriptions are
    supported, tested ti)

[1] https://lore.kernel.org/all/20240806-isolcpus-io-queues-v3-0-da0eecfeaf8b@suse.de

Signed-off-by: Daniel Wagner <dwagner@...e.de>
---
Daniel Wagner (5):
      scsi: replace blk_mq_pci_map_queues with blk_mq_hctx_map_queues
      scsi: hisi_sas: replace blk_mq_pci_map_queues with blk_mq_hctx_map_queues
      nvme: replace blk_mq_pci_map_queues with blk_mq_hctx_map_queues
      virtio: blk/scsi: replace blk_mq_virtio_map_queues with blk_mq_hctx_map_queues
      blk-mq: remove unused queue mapping helpers

Ming Lei (1):
      blk-mq: introduce blk_mq_hctx_map_queues

 block/Makefile                            |  2 --
 block/blk-mq-cpumap.c                     | 35 +++++++++++++++++++++++
 block/blk-mq-pci.c                        | 46 -------------------------------
 block/blk-mq-virtio.c                     | 46 -------------------------------
 drivers/block/virtio_blk.c                |  4 +--
 drivers/nvme/host/fc.c                    |  1 -
 drivers/nvme/host/pci.c                   |  4 +--
 drivers/pci/pci.c                         | 20 ++++++++++++++
 drivers/scsi/fnic/fnic_main.c             |  4 +--
 drivers/scsi/hisi_sas/hisi_sas.h          |  1 -
 drivers/scsi/hisi_sas/hisi_sas_v2_hw.c    | 20 +++++++-------
 drivers/scsi/hisi_sas/hisi_sas_v3_hw.c    |  5 ++--
 drivers/scsi/megaraid/megaraid_sas_base.c |  4 +--
 drivers/scsi/mpi3mr/mpi3mr.h              |  1 -
 drivers/scsi/mpi3mr/mpi3mr_os.c           |  3 +-
 drivers/scsi/mpt3sas/mpt3sas_scsih.c      |  4 +--
 drivers/scsi/pm8001/pm8001_init.c         |  3 +-
 drivers/scsi/pm8001/pm8001_sas.h          |  1 -
 drivers/scsi/qla2xxx/qla_nvme.c           |  4 +--
 drivers/scsi/qla2xxx/qla_os.c             |  4 +--
 drivers/scsi/smartpqi/smartpqi_init.c     |  8 +++---
 drivers/scsi/virtio_scsi.c                |  4 +--
 drivers/virtio/virtio.c                   | 31 +++++++++++++++++++++
 include/linux/blk-mq-pci.h                | 11 --------
 include/linux/blk-mq-virtio.h             | 11 --------
 include/linux/blk-mq.h                    |  5 ++++
 include/linux/pci.h                       | 11 ++++++++
 include/linux/virtio.h                    | 13 +++++++++
 28 files changed, 152 insertions(+), 154 deletions(-)
---
base-commit: 26e197b7f9240a4ac301dd0ad520c0c697c2ea7d
change-id: 20240912-refactor-blk-affinity-helpers-7089b95b4b10
prerequisite-message-id: 20240912-do-not-overwrite-pci-mapping-v1-1-85724b6cec49@...e.de
prerequisite-patch-id: 0d995b19a62289433fe888843af1baa6fd19aec7

Best regards,
-- 
Daniel Wagner <dwagner@...e.de>