[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <00860eb3-8c88-45d3-84f5-5f8f0f03c28c@app.fastmail.com>
Date: Fri, 13 Sep 2024 08:05:31 +0000
From: "Arnd Bergmann" <arnd@...db.de>
To: arturs.artamonovs@...log.com, "Catalin Marinas" <catalin.marinas@....com>,
"Will Deacon" <will@...nel.org>, "Greg Malysa" <greg.malysa@...esys.com>,
"Philipp Zabel" <p.zabel@...gutronix.de>, "Rob Herring" <robh@...nel.org>,
"Krzysztof Kozlowski" <krzk+dt@...nel.org>,
"Conor Dooley" <conor+dt@...nel.org>,
"Utsav Agarwal" <Utsav.Agarwal@...log.com>,
"Michael Turquette" <mturquette@...libre.com>,
"Stephen Boyd" <sboyd@...nel.org>,
"Linus Walleij" <linus.walleij@...aro.org>,
"Bartosz Golaszewski" <brgl@...ev.pl>,
"Thomas Gleixner" <tglx@...utronix.de>, "Andi Shyti" <andi.shyti@...nel.org>,
"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
"Jiri Slaby" <jirislaby@...nel.org>, "Olof Johansson" <olof@...om.net>,
soc@...nel.org
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, linux-clk@...r.kernel.org,
"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
linux-i2c@...r.kernel.org, linux-serial@...r.kernel.org,
adsp-linux@...log.com,
"Nathan Barrett-Morrison" <nathan.morrison@...esys.com>
Subject: Re: [PATCH 19/21] arm64: dts: adi: sc598: add device tree
On Thu, Sep 12, 2024, at 18:25, Arturs Artamonovs via B4 Relay wrote:
> +/ {
> + chosen {
> + stdout-path = &uart1;
> + bootargs = "earlycon=adi_uart,0x31003000 console=ttySC0,115200
> mem=224M";
> + };
You should not need the mem= and earlycon= arguments, as that data
is already part of the stdout-path property and the memory node.
> + aliases {
> + serial0 = &uart0;
> + serial2 = &uart2;
> + serial3 = &uart3;
> + };
The aliases are board specific, please only list the ones
that are actually enabled and wired on on a particular
board, and make the aliases match the labels on the board
rather than the internal components of hte chip.
> + cpus {
> + #address-cells = <0x2>;
> + #size-cells = <0x0>;
> +
> + cpu0: cpu@0 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a55";
> + reg = <0x0 0x0>;
> + enable-method = "spin-table";
> + cpu-release-addr = <0x0 0xdeadbeef>;
Is that the actual address? It looks like some placeholder
that should not have been here.
Arnd
Powered by blists - more mailing lists