linux-kernel - Re: [PATCH v1 1/2] xhci: pci: Use standard pattern for device IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZuQI98wLOyqGCLa7@smile.fi.intel.com>
Date: Fri, 13 Sep 2024 12:42:15 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Sergei Shtylyov <sergei.shtylyov@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Mathias Nyman <mathias.nyman@...ux.intel.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Mathias Nyman <mathias.nyman@...el.com>
Subject: Re: [PATCH v1 1/2] xhci: pci: Use standard pattern for device IDs

On Fri, Sep 13, 2024 at 11:51:48AM +0300, Sergei Shtylyov wrote:
> On 9/13/24 11:43 AM, Andy Shevchenko wrote:
> 
> > The definitions of vendor IDs are follow the pattern
> 
>    s/are//?

Yeah, thank you for catching this.

> > PCI_VENDOR_ID_#vendor, while device IDs — PCI_DEVICE_ID_#vendor_#device.
> > 
> > Update the ETRON device IDs to follow the above mentioned pattern.

[...]

> >  	if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
> > -			pdev->device == PCI_DEVICE_ID_EJ168) {
> > +	    pdev->device == PCI_DEVICE_ID_ETRON_EJ168) {
> >  		xhci->quirks |= XHCI_RESET_ON_RESUME;
> >  		xhci->quirks |= XHCI_BROKEN_STREAMS;
> >  	}
> >  	if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
> > -			pdev->device == PCI_DEVICE_ID_EJ188) {
> > +	    pdev->device == PCI_DEVICE_ID_ETRON_EJ188) {
> >  		xhci->quirks |= XHCI_RESET_ON_RESUME;
> >  		xhci->quirks |= XHCI_BROKEN_STREAMS;
> 
>    Hm, these 2 *if*s seem mergeable?

It's out of the scope of this mini-series, but seems a good catch!

-- 
With Best Regards,
Andy Shevchenko