linux-kernel - Re: [PATCH -next] fs/inode: Modify mismatched function name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240913102935.maz3vf42jkmcvfcn@quack3>
Date: Fri, 13 Sep 2024 12:29:35 +0200
From: Jan Kara <jack@...e.cz>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: viro@...iv.linux.org.uk, brauner@...nel.org, jack@...e.cz,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Abaci Robot <abaci@...ux.alibaba.com>, mhocko@...e.cz
Subject: Re: [PATCH -next] fs/inode: Modify mismatched function name

On Fri 13-09-24 09:10:04, Jiapeng Chong wrote:
> No functional modification involved.
> 
> fs/inode.c:242: warning: expecting prototype for inode_init_always(). Prototype was for inode_init_always_gfp() instead.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=10845
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

I think this is a fallout from Michal's patch [1] which will be respinned
anyway AFAIU. Michal, can you please fixup the kernel doc when sending new
version of the patch? Thanks!

								Honza

[1] https://lore.kernel.org/all/20240827061543.1235703-1-mhocko@kernel.org/

> ---
>  fs/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/inode.c b/fs/inode.c
> index c391365cdfa7..6763900a7a87 100644
> --- a/fs/inode.c
> +++ b/fs/inode.c
> @@ -229,7 +229,7 @@ static int no_open(struct inode *inode, struct file *file)
>  }
>  
>  /**
> - * inode_init_always - perform inode structure initialisation
> + * inode_init_always_gfp - perform inode structure initialisation
>   * @sb: superblock inode belongs to
>   * @inode: inode to initialise
>   * @gfp: allocation flags
> -- 
> 2.32.0.3.g01195cf9f
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR