[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c4ace228-ea32-4760-b6af-f7555b68063a@ti.com>
Date: Fri, 13 Sep 2024 16:27:47 +0530
From: Beleswar Prasad Padhi <b-padhi@...com>
To: Andrew Halaney <ahalaney@...hat.com>, Nishanth Menon <nm@...com>,
Vignesh
Raghavendra <vigneshr@...com>,
Tero Kristo <kristo@...nel.org>, Rob Herring
<robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley
<conor+dt@...nel.org>
CC: Keerthy <j-keerthy@...com>, Neha Malcom Francis <n-francis@...com>,
Eric
Chanudet <echanude@...hat.com>,
Enric Balletbo <eballetb@...hat.com>, Udit
Kumar <u-kumar1@...com>,
<linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] arm64: dts: ti: k3-j784s4-evm: Mark tps659413
regulators as bootph-all
Hi Andrew,
On 11/09/24 22:49, Andrew Halaney wrote:
> In order for the MCU domain to access this PMIC, a regulator
> needs to be marked appropriately otherwise it is not seen by SPL and
> therefore not configured.
>
> This is necessary if the MCU domain is to program the TPS6594 MCU ESM
> state machine, which is required to wire up the watchdog in a manner
> that will reset the board.
>
> Signed-off-by: Andrew Halaney <ahalaney@...hat.com>
> ---
> arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> index 6695ebbcb4d0..6ed628c2884e 100644
> --- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> @@ -663,6 +663,7 @@ tps659413: pmic@48 {
>
> regulators {
> bucka12: buck12 {
> + bootph-all;
> regulator-name = "vdd_ddr_1v1";
> regulator-min-microvolt = <1100000>;
> regulator-max-microvolt = <1100000>;
In my opinion, bootph-all property should come after other standard
properties like regulator-name etc., as it is least important to Linux.
Same comment for other nodes wherever applicable. What is your opinion?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n130
Thanks,
Beleswar
> @@ -671,6 +672,7 @@ bucka12: buck12 {
> };
>
> bucka3: buck3 {
> + bootph-all;
> regulator-name = "vdd_ram_0v85";
> regulator-min-microvolt = <850000>;
> regulator-max-microvolt = <850000>;
> @@ -679,6 +681,7 @@ bucka3: buck3 {
> };
>
> bucka4: buck4 {
> + bootph-all;
> regulator-name = "vdd_io_1v8";
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> @@ -687,6 +690,7 @@ bucka4: buck4 {
> };
>
> bucka5: buck5 {
> + bootph-all;
> regulator-name = "vdd_mcu_0v85";
> regulator-min-microvolt = <850000>;
> regulator-max-microvolt = <850000>;
> @@ -695,6 +699,7 @@ bucka5: buck5 {
> };
>
> ldoa1: ldo1 {
> + bootph-all;
> regulator-name = "vdd_mcuio_1v8";
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> @@ -703,6 +708,7 @@ ldoa1: ldo1 {
> };
>
> ldoa2: ldo2 {
> + bootph-all;
> regulator-name = "vdd_mcuio_3v3";
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
> @@ -711,6 +717,7 @@ ldoa2: ldo2 {
> };
>
> ldoa3: ldo3 {
> + bootph-all;
> regulator-name = "vds_dll_0v8";
> regulator-min-microvolt = <800000>;
> regulator-max-microvolt = <800000>;
> @@ -719,6 +726,7 @@ ldoa3: ldo3 {
> };
>
> ldoa4: ldo4 {
> + bootph-all;
> regulator-name = "vda_mcu_1v8";
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
>
Powered by blists - more mailing lists