linux-kernel - Re: [PATCH] pinctrl: pinctrl-cy8c95x0: Fix regcache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdaRRFfB_HQaYQCKtdqhy7Cx-AjdtQnJVACRO13z++eLmQ@mail.gmail.com>
Date: Fri, 13 Sep 2024 13:15:13 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Patrick Rudolph <patrick.rudolph@...ements.com>
Cc: Andy Shevchenko <andy@...nel.org>, naresh.solanki@...ements.com, 
	andy.shevchenko@...il.com, broonie@...nel.org, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: pinctrl-cy8c95x0: Fix regcache

On Mon, Sep 2, 2024 at 9:30 AM Patrick Rudolph
<patrick.rudolph@...ements.com> wrote:

> The size of the mux stride was of by one, which could result in
> invalid pin configuration on the device side or invalid state
> readings on the software side.
>
> While on it also update the code and:
> - Increase the mux stride size to 16
> - Align the virtual muxed regmap range to 16
> - Start the regmap window at the selector
> - Mark reserved registers as not-readable
>
> Fixes: 8670de9fae49 ("pinctrl: cy8c95x0: Use regmap ranges")
> Signed-off-by: Patrick Rudolph <patrick.rudolph@...ements.com>

I was waiting for a follow-up fixing Andy's small remarks but now I just
applied this and fixed up the nits myself.

Yours,
Linus Walleij