linux-kernel - Re: [PATCH] fs/ntfs3: Remove the unnecessary 'if' statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZuOkd8dMur08t0zo@iZbp1asjb3cy8ks0srf007Z>
Date: Fri, 13 Sep 2024 10:33:27 +0800
From: Qianqiang Liu <qianqiang.liu@....com>
To: almaz.alexandrovich@...agon-software.com
Cc: ntfs3@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/ntfs3: Remove the unnecessary 'if' statement

Hi almaz,

On Wed, Sep 11, 2024 at 09:57:54AM +0800, Qianqiang Liu wrote:
> The 'asize' was already checked to be less than SIZEOF_RESIDENT.
> 
> Signed-off-by: Qianqiang Liu <qianqiang.liu@....com>
> ---
>  fs/ntfs3/record.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/ntfs3/record.c b/fs/ntfs3/record.c
> index 427c71be0f08..0f400366231d 100644
> --- a/fs/ntfs3/record.c
> +++ b/fs/ntfs3/record.c
> @@ -268,10 +268,6 @@ struct ATTRIB *mi_enum_attr(struct mft_inode *mi, struct ATTRIB *attr)
>  
>  	/* Check size of attribute. */
>  	if (!attr->non_res) {
> -		/* Check resident fields. */
> -		if (asize < SIZEOF_RESIDENT)
> -			return NULL;
> -
>  		t16 = le16_to_cpu(attr->res.data_off);
>  		if (t16 > asize)
>  			return NULL;
> -- 
> 2.39.2

Could you please review this patch?

-- 
Best,
Qianqiang Liu