linux-kernel - Re: [PATCH] pmdomain: rockchip: Simplify dropping OF node reference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <186de981-7a3c-4fdb-8911-8dfee597c759@web.de>
Date: Fri, 13 Sep 2024 15:16:09 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 linux-pm@...r.kernel.org, kernel-janitors@...r.kernel.org,
 linux-rockchip@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 cocci@...ia.fr, Heiko Stübner <heiko@...ech.de>,
 Ulf Hansson <ulf.hansson@...aro.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pmdomain: rockchip: Simplify dropping OF node reference

> Drop OF node reference immediately after using it in
> syscon_node_to_regmap(), which is both simpler and typical/expected
> code pattern.

Dear Krzysztof,

I noticed also this contribution.
I found it easy to convert it also into the following small script variant
for the semantic patch language (Coccinelle software).

@adjustment@
expression e, x;
@@
+of_node_put(e);
 if (...)
 {
 <+... when != e = x
-   of_node_put(e);
 ...+>
 }
-of_node_put(e);

58 patches were accordingly generated for source files of the software “Linux next-20240913”.
How would we like to tackle remaining update candidates according to similar transformation patterns?

Regards,
Markus