linux-kernel - Re: [PATCH] crypto: Removing CRYPTO_AES_GCM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89493ea2-b145-489c-94a5-dad8608b9b79@linux.ibm.com>
Date: Fri, 13 Sep 2024 09:02:21 -0500
From: Danny Tsen <dtsen@...ux.ibm.com>
To: Christophe Leroy <christophe.leroy@...roup.eu>,
        linux-crypto@...r.kernel.org
Cc: herbert@...dor.apana.org.au, leitao@...ian.org, nayna@...ux.ibm.com,
        appro@...ptogams.org, linux-kernel@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, mpe@...erman.id.au,
        ltcgcw@...ux.vnet.ibm.com, dtsen@...ibm.com
Subject: Re: [PATCH] crypto: Removing CRYPTO_AES_GCM_P10.

Got it.  Thanks.

-Danny

On 9/13/24 8:55 AM, Christophe Leroy wrote:
>
>
> Le 13/09/2024 à 14:30, Danny Tsen a écrit :
>> [Vous ne recevez pas souvent de courriers de dtsen@...ux.ibm.com. 
>> Découvrez pourquoi ceci est important à 
>> https://aka.ms/LearnAboutSenderIdentification ]
>>
>> Removing CRYPTO_AES_GCM_P10 in Kconfig first so that we can apply the
>> subsequent patches to fix data mismatch over ipsec tunnel.
>
> To deactivate a driver, all you have to do is to add:
>
>     depends on BROKEN
>
> Christophe
>
>
>>
>> Signed-off-by: Danny Tsen <dtsen@...ux.ibm.com>
>> ---
>>   arch/powerpc/crypto/Kconfig | 32 ++++++++++++++++----------------
>>   1 file changed, 16 insertions(+), 16 deletions(-)
>>
>> diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig
>> index 09ebcbdfb34f..96ca2c4c8827 100644
>> --- a/arch/powerpc/crypto/Kconfig
>> +++ b/arch/powerpc/crypto/Kconfig
>> @@ -105,22 +105,22 @@ config CRYPTO_AES_PPC_SPE
>>            architecture specific assembler implementations that work 
>> on 1KB
>>            tables or 256 bytes S-boxes.
>>
>> -config CRYPTO_AES_GCM_P10
>> -       tristate "Stitched AES/GCM acceleration support on P10 or 
>> later CPU (PPC)"
>> -       depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
>> -       select CRYPTO_LIB_AES
>> -       select CRYPTO_ALGAPI
>> -       select CRYPTO_AEAD
>> -       select CRYPTO_SKCIPHER
>> -       help
>> -         AEAD cipher: AES cipher algorithms (FIPS-197)
>> -         GCM (Galois/Counter Mode) authenticated encryption mode 
>> (NIST SP800-38D)
>> -         Architecture: powerpc64 using:
>> -           - little-endian
>> -           - Power10 or later features
>> -
>> -         Support for cryptographic acceleration instructions on 
>> Power10 or
>> -         later CPU. This module supports stitched acceleration for 
>> AES/GCM.
>> +#config CRYPTO_AES_GCM_P10
>> +#      tristate "Stitched AES/GCM acceleration support on P10 or 
>> later CPU (PPC)"
>> +#      depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
>> +#      select CRYPTO_LIB_AES
>> +#      select CRYPTO_ALGAPI
>> +#      select CRYPTO_AEAD
>> +#      select CRYPTO_SKCIPHER
>> +#      help
>> +#        AEAD cipher: AES cipher algorithms (FIPS-197)
>> +#        GCM (Galois/Counter Mode) authenticated encryption mode 
>> (NIST SP800-38D)
>> +#        Architecture: powerpc64 using:
>> +#          - little-endian
>> +#          - Power10 or later features
>> +#
>> +#        Support for cryptographic acceleration instructions on 
>> Power10 or
>> +#        later CPU. This module supports stitched acceleration for 
>> AES/GCM.
>>
>>   config CRYPTO_CHACHA20_P10
>>          tristate "Ciphers: ChaCha20, XChacha20, XChacha12 (P10 or 
>> later)"
>> -- 
>> 2.43.0
>>
>>