linux-kernel - Re: [PATCH net-next v3 1/2] netpoll: Make netpoll_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240913-honest-mindful-ermine-514d3e@leitao>
Date: Fri, 13 Sep 2024 07:35:47 -0700
From: Breno Leitao <leitao@...ian.org>
To: Maksym Kutsevol <max@...sevol.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Alex Deucher <alexander.deucher@....com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 1/2] netpoll: Make netpoll_send_udp return
 status instead of void

On Thu, Sep 12, 2024 at 10:28:51AM -0700, Maksym Kutsevol wrote:
> netpoll_send_udp can return if send was successful.
> It will allow client code to be aware of the send status.
> 
> Possible return values are the result of __netpoll_send_skb (cast to int)
> and -ENOMEM. This doesn't cover the case when TX was not successful
> instantaneously and was scheduled for later, __netpoll__send_skb returns
> success in that case.
> 
> Signed-off-by: Maksym Kutsevol <max@...sevol.com>

Reviewed-by: Breno Leitao <leitao@...ian.org>

Thanks for addressing it. Two things you might want to consider:

1) There are some warnings related to this patch.
 a) Not CCed maintainers
 b) WARNING: line length of 95 exceeds 80 columns

You can see them here:
https://patchwork.kernel.org/project/netdevbpf/patch/20240912173608.1821083-2-max@kutsevol.com/

Also, this might conflict with the refactor I did a while ago, so, you
might need to rebase:

https://lore.kernel.org/all/20240910100410.2690012-1-leitao@debian.org/

Other than that, I am happy with it.

Thanks for doing it
-breno